Re: Building libfetch and fetch in-tree

[Joerg Sonnenberger <joerg%britannica.bec.de@localhost>]

On Wed, Oct 02, 2013 at 12:02:41AM +0200, Pierre Pronchery wrote:
> On 01/10/2013 23:43, Joerg Sonnenberger wrote:
> > Please stop doing random things. Stop hacking to make random things
> > seemingly work. The pkgsrc build system easily allows building a debug
> > version. It easily allows changing things and running rebuild. You know,
> > people have been debugging this code before.
> 
> I am not doing random things. I am merely protecting an include of
> nbcompat.h exactly as (properly) detected by the configure script, and
> as advertized by config.h, and additionally explicitly provided by
> pkgsrc itself (through the features feature). That makes two safeguards,
> and the end result is more portable.

No, you don't. The code cares about exactly two different modes:
(1) pkgsrc
(2) NetBSD src 

Please do not introduce burden for maintainance by adding a third mode.
Most noticable, (2) is not equal to "build on NetBSD".

Joerg