tech-pkg archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: lua51/lua52 packages and multiversion support



On Tue, Oct 29, 2013 at 11:22:45PM +0000, Alexander Nasonov wrote:
 > I have some minor comments:
 > 
 > +# REPLACE_LUA
 > +#   A list of Lau scripts ot be installed, relative to ${WRKSRC}.
 > 
 > Lau -> Lua

Oops...

 > +LUA_VERSION_DEFAULT?=       51
 > 
 > Why are you changing it back to 5.1?

We're here because 5.2 doesn't work with a lot of things.

 > +_PYTHON_VERSION?=   none
 > 
 > Shouldn't it be _LUA_VERSION?

Yes! gack.

 > > I will commit this tomorrow or thereabouts unless there's a lot of
 > > shouting, because it's readily susceptible to bitrot otherwise.
 > 
 > Sounds good to me. It would definitely took me more time to prepare a
 > commitable patch.
 > 
 > Thanks for working on this.

You're welcome. :-)

We'll still want your changes to make the two Lua packages installable
simultaneously, I think.

-- 
David A. Holland
dholland%netbsd.org@localhost


Home | Main Index | Thread Index | Old Index