Re: wip/mk/git-package.mk cleanups

[Thomas Klausner <tk%giga.or.at@localhost>]

On Tue, May 06, 2014 at 12:47:32PM -0400, Richard Hansen wrote:
> On 2014-05-06 08:30, Thomas Klausner wrote:
> > Hi Richard!
> > 
> > Thanks for all your work on this! The patches look quite good.
> 
> Are you OK with the WRKSRC symlink?  (for now anyway)

As I understand it, it's overridable, so it looks ok to me.

> I actually added positively named variables to cvs-, git-, and
> hg-package.mk before I noticed that svn-package.mk already had
> NO_SVN_CACHE.  Are you OK with breaking compatibility by renaming
> NO_SVN_CACHE?  If so, I'd be happy to rename everything to
> CACHE_{CVS,GIT,HG,SVN} (I prefer positive variable names too).

Yes, please.

> Alternatively I can support both CACHE_SVN and NO_SVN_CACHE and add a
> deprecation warning if defined(NO_SVN_CACHE).

Wait for someone to speak up for that option first before putting any
more work in it.

Thanks,
 Thomas