Aleksej Saushev <asau%inbox.ru@localhost> writes: > Richard Hansen <rhansen%bbn.com@localhost> writes: > >> On 2014-05-06 08:30, Thomas Klausner wrote: >>>> Subject: [PATCH 05/13] use :Q modifier to escape special shell characters >>> >>> Did this actually fix anything or is it just for safety? >> >> Just for safety. Sorry for not mentioning that in the commit message; >> I'll update it in the next re-roll. > > I'm sceptical of such changes too. Could you keep them for another time? What do you mean by skeptical? It seems that quoting is hard and annoying to get right, and that we perhaps do not insist on perfection (certainly, no test suite with ridiculous variable contents). But it seems that doing it incrementally better is perfectly ok, and I don't see why it's objectionable.
Attachment:
pgpYR8IbwV2RU.pgp
Description: PGP signature