Re: vlc-2.2.1 crash in module loader

["Ian D. Leroux" <idleroux%fastmail.fm@localhost>]

On Sat, 4 Jul 2015 16:00:26 +0200 "Ian D. Leroux"
<idleroux%fastmail.fm@localhost> wrote:
> Lacking any better ideas, I'll probably start going through the
> uncommented patches I brought over from multimedia/vlc21 and see if
> they all still make sense.

Puzzling patches:

patch-bin_override.c
  Essentially comments out the entirety of bin/override.c (with an
  #if 0), but then proceeds to make adjustments to the commented-
  out code (adding a const qualifier to an argument of a putenv
  function definition that does not survive the preprocessor).

patch-modules_gui_qt4_components_controller.cpp
patch-modules_gui_qt4_components_extended__panels.cpp
patch-modules_gui_qt4_components_interface__widgets.cpp
patch-modules_gui_qt4_components_interface__widgets.hpp
patch-modules_gui_qt4_input__manager.cpp
patch-modules_gui_qt4_input__manager.hpp
patch-modules_gui_qt4_util_input__slider.cpp
patch-modules_gui_qt4_util_input__slider.hpp
  These (about half of the patches/) are entirely concerned with
  unconditionally defining putime_t as a typedef for int64_t and using
  that.  While I agree with the change on stylistic grounds, it's not
  clear to me that we want to be maintaining style fixes in pkgsrc
  patches/.  Do they fill any functional need?

patch_compat_Makefile.am
patch_compat_Makefile.in
patch-modules_access_rtp_Makefile.am
  These arrange for vlc's compatibility library to be built and linked
  dynamically.  I bring this up because the mixture of unexpected
  dynamic linking (according to the patch comment, upstream wants the
  compat library to be statically linked in plugins) and multi-threading
  in the plugins seems like it might have something to do with the
  crashes we're seeing.

--
IDL