Re: wip/tme ready for review

[phabrics%phabrics.com@localhost]

On 2015-07-15 04:29, Kamil Rytarowski wrote:
> Impressive work.

Thanks, Kamil!

> My comments:
> - - You use DESCR to say about the upcoming release ("New in this
> release..."). From my experience DESCR can quickly get out of sync
> with reality and it's better to note there just general info what the
> package does.

I will change it to back to a general description.  This was only to 
distinguish
it from the original in pkgsrc.

> - - Do we need this MESSAGE?

Given the discussion earlier this year, I can probably take it out.

> - - Version 0.10beta_6 - can we make it saner? Alphanumerical versions
> tend to introduce issues with maintaining upgrades and comparing
> version. Do you know whether 0.10 > 0.10beta_6 for pkgsrc? For RPM and
> pkg-config it's false.

I was gonna make it 0.10 for release.  However, I can look for a 
different number.
Original numbering scheme used 0.2 increments; original, I went to 1.0, 
but
upstream told me 0.10 was next.

> - - Do we need this CONFLICTS?
Not for pkgsrc.  Again, this was only to distinguish from original 
package in pkgsrc.

> - - Lines 27-55 adding -W* and -f*, can you put these rules inside your
> package? This shouldn't be maintained from pkgsrc.
Yes, I can.  I will do that!

Thank you for your feedback.

Regards,
Ruben