Re: sysutils/dbus 1.10.0 problems

[Thomas Klausner <wiz%NetBSD.org@localhost>]

On Mon, Sep 21, 2015 at 08:35:46AM +0900, Ryo ONODERA wrote:
> From: Ryo ONODERA <ryo_on%yk.rim.or.jp@localhost>, Date: Sat, 19 Sep 2015 09:53:48 +0900 (JST)
> 
> > Hi,
> > 
> > From: Greg Troxel <gdt%ir.bbn.com@localhost>, Date: Fri, 18 Sep 2015 19:50:33 -0400
> > 
> >> 
> >> To me the big issue is that if files are installed under share, then the
> >> user must not modify them.  It seems that if you want to modify config,
> >> you put a config file in etc, and that's read instead of the one in
> >> share.  So the files in share are not really "config files" in the usual
> >> sense.  So I think they shouldn't use CONF_FILES.  Basically the
> >> following three should always go together:
> >> 
> >>   being in etc (PKG_SYSCONFBASE really)
> >>   being user modifable
> >>   CONF_FILES
> >> 
> >> So we need to be clear on whether these files in share can be modified
> >> by the user or not.
> > 
> > Thanks for your comment.
> > I read dbus distribution files including NEWS again and I find
> > I misunderstood their policy for configuration files.
> > The following patch is sufficient.
> 
> Sorry previous patch has typo.
> 
> Index: Makefile
> ===================================================================
> RCS file: /cvsroot/pkgsrc/sysutils/dbus/Makefile,v
> retrieving revision 1.87
> diff -u -r1.87 Makefile
> --- Makefile	7 Sep 2015 23:24:46 -0000	1.87
> +++ Makefile	20 Sep 2015 23:33:48 -0000
> @@ -1,6 +1,7 @@
>  # $NetBSD: Makefile,v 1.87 2015/09/07 23:24:46 gdt Exp $
>  
>  DISTNAME=	dbus-1.10.0
> +PKGREVISION=	1
>  CATEGORIES=	sysutils
>  MASTER_SITES=	http://dbus.freedesktop.org/releases/dbus/
>  
> @@ -69,6 +70,12 @@
>  
>  PLIST_VARS+=    	linux launchd
>  
> +DBUS_CONF_DIR+=		${PKG_SYSCONFBASE}/dbus-1
> +OWN_DIRS+=		${DBUS_CONF_DIR}/services 
> +OWN_DIRS+=		${DBUS_CONF_DIR}/system-services 
> +OWN_DIRS+=		${DBUS_CONF_DIR}/session.d
> +OWN_DIRS+=		${DBUS_CONF_DIR}/system.d
> +
>  RCD_SCRIPTS=		dbus
>  
>  PKG_GROUPS_VARS+=	DBUS_GROUP
> 

Please commit. Thanks!
 Thomas