Re: make environment during packaging?

[Brook Milligan <brook%nmsu.edu@localhost>]

> On Jul 1, 2016, at 12:01 AM, Joerg Sonnenberger <joerg%bec.de@localhost> wrote:
> 
> On Thu, Jun 30, 2016 at 07:47:08AM -0600, Brook Milligan wrote:
>> I am working on a package with a Makefile mostly set up for destdir support; its Makefiles have, for example, ${destdir}${bindir}/… in appropriate places.  However, the value of ${destdir} is not set anywhere.  It would seem that I could export destdir=${DESTDIR} into the environment during packaging and have this work, but that seems not to work.
> 
> Normally, you get that effect by using INSTALL_MAKE_FLAGS or
> INSTALL_MAKE_ENV.

Thanks a lot for that pointer.  However …

‘make debug’ makes no mention of INSTALL_MAKE_ENV and sysutils/munin-server/Makefile has the only instance of that string in a pretty recent checkout of pkgsrc.  Is that a mistake that should be switched to INSTALL_MAKE_FLAGS?  Should INSTALL_MAKE_ENV be implemented somewhere?

In contrast, ‘make debug’ does mention INSTALL_MAKE_FLAGS and that is referenced numerous places.  However, INSTALL_MAKE_FLAGS is not documented in mk/install/install.mk; it seems that is should be.  As a side note, some of the package Makefiles use ‘=‘ rather than ‘+=‘; are these supposed to be ‘+=‘?

In any case, for now I have used 'INSTALL_MAKE_FLAGS+=destdir=${DESTDIR}’, which works perfectly.

Thanks.

Cheers,
Brook