Re: OS X: error: 'gitypes.h' file not found with <angled> include; use "quotes" instead

["Todd M. Kover" <kovert%omniscient.com@localhost>]

It seems to be getting stripped out.  (That's basically what the CFLAGS
entry I had below did).  The two platforms I typically use for pkgsrc
are NetBSD and macOS, and I seem to have a lot of weird compiler-type
issues with the latter that don't show up with the former that I've
always attributed to clang being extra pedantic.

I rebuilt from scratch, this time without having the CFLAGS.Darwin
entry in my Makefile, and it still ends up with the equivilent of
-I./girepository in the "before" and that is getting stripped out by the
wrappers:

[*] cc -E -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk -I/opt/pkg/include -DGI_COMPILATION -U__BLOCKS__ -I. -I/private/var/pkg/obj/devel/gobject-introspection/work.x86_64/gobject-introspection-1.48.0/girepository -I/private/var/pkg/obj/devel/gobject-introspection/work.x86_64/gobject-introspection-1.48.0 -I/opt/pkg/include/glib/glib-2.0 -I/opt/pkg/lib/glib-2.0/include -I/opt/pkg/include -o g-ir-cpp-h_HZrh.i -C /var/folders/bz/cnrp3_q52x17_dhvgp0f2wfc0000m2/T/g-ir-cpp-h_HZrh.c
<.> /usr/bin/clang -E -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk -I/p/pkg/obj/devel/gobject-introspection/work.x86_64/.buildlink/include -DGI_COMPILATION -U__BLOCKS__ -I. -I/p/pkg/obj/devel/gobject-introspection/work.x86_64/.buildlink/include/glib/glib-2.0 -I/p/pkg/obj/devel/gobject-introspection/work.x86_64/.buildlink/lib/glib-2.0/include -o g-ir-cpp-h_HZrh.i -C /var/folders/bz/cnrp3_q52x17_dhvgp0f2wfc0000m2/T/g-ir-cp

OBJDIR is set to /p/pkg/obj in this case, which through a myriad of symlinks
ends up being /private/var/pkg/obj.

So it looks like in this case, its something about how the wrappers are
working (perhaps only in macOS) and its stripping out the -I./gitrepository
equivalent.

Also, I did not mention this in my last message, but I'm running macOS
Sierra (10.12.1) and XCode 8, which is different than the earlier bug
report (although I've run into this exact problem off-and-on over time).

-Todd

 > I'm wondering why it would be broken int he first place. it's not broken on
 > other platforms.
 > 
 > I see -I./girepository in my build.
 > 
 > Does adding an include dir like that not work for you?
 > 
 > On Sun, Oct 30, 2016 at 10:34:40PM -0400, Todd M. Kover wrote:
 > > I came at this a little backwards from the "what do I need to get it to
 > > build, but maybe not right?"
 > > 
 > > adding to .cwrapper/config/cc, the equivalent of:
 > > 
 > > transform=I:${WRKSRC}/girepository:${WRKSRC}/girepository
 > > transform=I:${WRKSRC}/tests:${WRKSRC}/tests
 > > 
 > > which seemed to get it working.  I had added:
 > > 
 > > CFLAGS.Darwin += ${WRKSRC}/girepository
 > > 
 > > but it was stripped away by the wrappers.  (it was still in when I added
 > > the above, so wanted to mention it).
 > > 
 > > I'm sure there's a right way to do deal with this but I was not able to
 > > discern it glancing at the cwrappers docs or pkgsrc buildlink docs (I'll
 > > admit that I did not try hard).  If someone can give me a pointer to the
 > > "right" way to accomplish this, I can sort it out and open a pr.
 > > 
 > > thanks,
 > > -Todd
 > > 
 > > 
 > >  > trying to build pkgsrc/devel/gobject-introspection, I get a log of errors 
 > >  > like this:
 > >  > 
 > >  > In file included from
 > >  > /Users/feyrer/work/NetBSD/cvs/pkgsrc/devel/gobject-introspection/work.promise/gobject-introspection-1.48.0/gire
posit
 > > ory/girepository.h:41:
 > >  > /Users/feyrer/work/NetBSD/cvs/pkgsrc/devel/gobject-introspection/work.promise/gobject-introspection-1.48.0/gire
posit
 > > ory/giregisteredtypeinfo.h:31:10:
 > >  > error: 'gitypes.h' file not found with <angled> include; use "quotes"
 > >  > instead
 > >  > #include <gitypes.h>
 > >  > ^~~~~~~~~~~
 > >  > "gitypes.h"
 > >  > fatal error: too many errors emitted, stopping now [-ferror-limit=]
 > >  > 20 errors generated.
 > >  > 
 > >  > Making the suggested change indeed gets things further, but it's many 
 > >  > files.
 > >  > 
 > >  > Has anyone dived deep enough into the funny build system to fix this in a 
 > >  > proper way, probably by adding -I... in one place?
 > >  > 
 > >  > OS information:
 > >  > 
 > >  > Mac OS X 10.10.5
 > >  > 
 > >  > promise% uname -a
 > >  > Darwin promise.local 14.5.0 Darwin Kernel Version 14.5.0: Thu Jun 16 
 > >  > 19:58:21 PDT 2016; root:xnu-2782.50.4~1/RELEASE_X86_64 x86_64
 > >  > 
 > >  > promise% xcodebuild -version
 > >  > Xcode 7.2
 > >  > Build version 7C68
 > >  > 
 > >  > Command line tools installed by recommendation. Unsure if this isn't 
 > >  > involved in the problem.
 > >  > 
 > >  > 
 > >  > - Hubert
 > >  > 
 > > 
 >