Re: How do I remove package from pkgsrc-wip?

[Miwa Susumu <miwarin%gmail.com@localhost>]

2018-05-28 0:08 GMT+09:00 Greg Troxel <gdt%lexort.com@localhost>:
>
> Miwa Susumu <miwarin%gmail.com@localhost> writes:
>
>> 2018-05-24 0:32 GMT+09:00 Thomas Klausner <wiz%netbsd.org@localhost>:
>>> On Thu, May 24, 2018 at 12:31:16AM +0900, Miwa Susumu wrote:
>>>> package does not exist(MASTER_SITE not found, domain expired...).
>>>> remove package from pkgsrc-wip. is procedure ok?
>>>>
>>>> 1. remove package file and directory.
>>>> 2. remove package name from wip/Makefile.
>>>> 3. git commit, git push.
>>>
>>> Yes, that works.
>
> Can you explain a bit more about how you are deciding to remove things?
>
> In pkgsrc proper, removal of packages is almost always preceded by a
> note to the list proposing to remove, and the criteria are more or less:
>
>   - upstream package is really not maintained
>
>   - upstream package is so out of date that nobody should run it
>
>   - it is believed that there are almost no users, or it is so unwise to
>     run it that we are comfortable telling anybody running it that they
>     are out of luck, without understanding their situation

First. check if MASTER_SITE is not found.
Next. I google file name of the package, if it can not be found, I
delete the package.

For example.some package MASTER_SITE is not found.
but I google file name of the package, I can found other site.(e.g. github)
In that case I don't remove package. I will change the package
MASTER_SITE etc at a later date.

> Also, some people do package proprietary software, so restricted
> downloads are a normal case and not cause for removal.  (I sent you a
> private note asking for a revert of the removal of a package with a
> download link.)

Thanks.
That's mistake.

> From your commit messages, I see "MASTER_SITES not found", which is much
> less than the typical reason.  I suspect that in many cases, trying to
> find an upstream would reveal that there has not been any activity for
> many years, and the normal criteria are in fact met.  I wonder if you
> have been doing that, or just noting that a script failed to fetch from
> the MASTER_SITES variable?

As above, I am handling it manually.
I didn't 'make fetch'.
I am deleting package, is I found when I ran pkglint -e the other day
and searched
for a package that LICENSE was missing.

> Finally, there is a MAINTAINER field, and I hope you have been writing
> to MAINTAINER before removing -- but I haven't seen "mail to $MAINTAINER
> bounced" in any commit messages.

agree.
I didn't communicate MAINTAINER.

> In general, I do think it is good to clean up cruft.  The hard question
> is what exactly is cruft, vs useful to someone.  So I'm just asking for
> a little more clarity about your process, given that you are into "large
> scale changes" territory.

Thanks advice.

I will run pbulk at a later date and plan to fix the package that
caused the error.
It may only modify the Makefile, or it may delete the package.

and I will communicate MAINTAINER before remove package.

-- 
miwarin