Re: Fix subst SUBST_NOOP_OK?=yes fallout

[Jonathan Perkin <jperkin%joyent.com@localhost>]

* On 2020-06-23 at 18:28 BST, Roland Illig wrote:

> Can you run the following lines before and after the fix? Just to make
> sure that the subst.mk test suite would have caught this pdksh bug.
> 
> cd regress/infra-unittests
> sh subst.sh

Before the fix everything fails (44 "assertion failed in ...").

After the fix I still see some failures:

  $ pdksh subst.sh
  assertion failed in "brackets in filename patterns": file "*" has unexpected content:
  --- /tmp/infra-unittests-47062/expected
  +++ *
  @@ -1 +1 @@
  -after
  +before

  assertion failed in "brackets in filename patterns": file "[*]" has unexpected content:
  --- /tmp/infra-unittests-47062/expected
  +++ [*]
  @@ -1 +1 @@
  -before
  +after

  assertion failed in "unreadable file": file "/tmp/infra-unittests-47062/output" has unexpected content:
  --- /tmp/infra-unittests-47062/expected
  +++ /tmp/infra-unittests-47062/output
  @@ -1,7 +1 @@
   => Substituting "id" in unreadable-file
  -sh: cannot open unreadable-file: permission denied
  -sh: cannot open unreadable-file: permission denied
  -*** Error code 1
  -
  -Stop.
  -bmake: stopped in /tmp/infra-unittests-47062/work

> How to make people run the test suite is a totally different
> question though.

Hook it into pbulk and make it a simple on/off variable.

-- 
Jonathan Perkin  -  Joyent, Inc.  -  www.joyent.com