Re: Fix for bootstrapping on macOS

[Pierre Pronchery <khorben%defora.org@localhost>]

[sending again with a smaller version of the log]

On 23/09/2020 22:28, Joerg Sonnenberger wrote:
> On Wed, Sep 23, 2020 at 08:15:43PM +0200, Pierre Pronchery wrote:
> > I just tested bootstrapping pkgsrc on macOS with the pkgsrc-2020Q2 branch,
> > plus the fix from schmonz@ for the latest version of Xcode. It failed with
> > missing function declarations in libarchive.
>
> What's the actual problem? The patch is certainly not correct.

The build log without my patch is attached here.

With the changes I posted earlier, it bootstraps fine.

Cheers,
--
khorben

===> bootstrap command: ./bootstrap --prefix /Users/khorben/pkg2 --unprivileged
===> bootstrap started: Thu Sep 24 16:19:19 CEST 2020
Working directory is: /Users/khorben/Projects/EdgeBSD/pkgsrc/bootstrap/work
[...]
===> running: (cd /Users/khorben/Projects/EdgeBSD/pkgsrc/bootstrap/work/pkg_install; env  CPPFLAGS=' -I/Users/khorben/Projects/EdgeBSD/pkgsrc/bootstrap/work/libnbcompat -I/Users/khorben/Projects/EdgeBSD/pkgsrc/bootstrap/work/libarchive/libarchive' LDFLAGS=' -L/Users/khorben/Projects/EdgeBSD/pkgsrc/bootstrap/work/libnbcompat' LIBS=' -lnbcompat' /bin/sh ./configure  -C --enable-bootstrap --prefix=/Users/khorben/pkg2 --sysconfdir=/Users/khorben/pkg2/etc --with-pkgdbdir=/Users/khorben/pkg2/pkgdb --infodir=/Users/khorben/pkg2/info --mandir=/Users/khorben/pkg2/man  && STATIC_LIBARCHIVE=/Users/khorben/Projects/EdgeBSD/pkgsrc/bootstrap/work/libarchive/.libs/libarchive.a PKGSRC_MACHINE_ARCH=x86_64 /Users/khorben/Projects/EdgeBSD/pkgsrc/bootstrap/work/bin/bmake  -j1)
configure: creating cache config.cache
checking build system type... x86_64-apple-darwin19.6.0
checking host system type... x86_64-apple-darwin19.6.0
[...]
cc -isystem /usr/include -DHAVE_CONFIG_H -DDEF_LOG_DIR=\"/Users/khorben/pkg2/pkgdb\" -I/Users/khorben/Projects/EdgeBSD/pkgsrc/bootstrap/work/libnbcompat -I/Users/khorben/Projects/EdgeBSD/pkgsrc/bootstrap/work/libarchive/libarchive -I. -I. -DSYSCONFDIR=\"/Users/khorben/pkg2/etc\" -DBOOTSTRAP -g -O2 -c pkg_io.c
In file included from pkg_io.c:58:
./lib.h:243:9: warning: 'IS_URL' macro redefined [-Wmacro-redefined]
#define IS_URL(str)     (URLlength(str) > 0)
        ^
pkg_io.c:53:9: note: previous definition is here
#define IS_URL(x) 0
        ^
1 warning generated.
[...]
cc -isystem /usr/include -DHAVE_CONFIG_H -DDEF_LOG_DIR=\"/Users/khorben/pkg2/pkgdb\" -I/Users/khorben/Projects/EdgeBSD/pkgsrc/bootstrap/work/libnbcompat -I/Users/khorben/Projects/EdgeBSD/pkgsrc/bootstrap/work/libarchive/libarchive -I. -I. -DSYSCONFDIR=\"/Users/khorben/pkg2/etc\" -DBOOTSTRAP -g -O2 -c vulnerabilities-file.c
vulnerabilities-file.c:83:22: error: implicit declaration of function 'archive_read_new' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
        struct archive *a = archive_read_new();
                            ^
vulnerabilities-file.c:83:18: warning: incompatible integer to pointer conversion initializing 'struct archive *' with an expression of type 'int' [-Wint-conversion]
        struct archive *a = archive_read_new();
                        ^   ~~~~~~~~~~~~~~~~~~
vulnerabilities-file.c:87:2: error: implicit declaration of function 'archive_read_support_filter_gzip' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
        archive_read_support_filter_gzip(a);
        ^
vulnerabilities-file.c:88:2: error: implicit declaration of function 'archive_read_support_filter_bzip2' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
        archive_read_support_filter_bzip2(a);
        ^
vulnerabilities-file.c:88:2: note: did you mean 'archive_read_support_filter_gzip'?
vulnerabilities-file.c:87:2: note: 'archive_read_support_filter_gzip' declared here
        archive_read_support_filter_gzip(a);
        ^
vulnerabilities-file.c:89:2: error: implicit declaration of function 'archive_read_support_filter_xz' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
        archive_read_support_filter_xz(a);
        ^
vulnerabilities-file.c:89:2: note: did you mean 'archive_read_support_filter_gzip'?
vulnerabilities-file.c:87:2: note: 'archive_read_support_filter_gzip' declared here
        archive_read_support_filter_gzip(a);
        ^
vulnerabilities-file.c:90:2: error: implicit declaration of function 'archive_read_support_format_raw' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
        archive_read_support_format_raw(a);
        ^
vulnerabilities-file.c:90:2: note: did you mean 'archive_read_support_filter_xz'?
vulnerabilities-file.c:89:2: note: 'archive_read_support_filter_xz' declared here
        archive_read_support_filter_xz(a);
        ^
1 warning and 5 errors generated.
*** [vulnerabilities-file.o] Error code 1

bmake[1]: stopped in /Users/khorben/Projects/EdgeBSD/pkgsrc/bootstrap/work/pkg_install/lib
1 error

bmake[1]: stopped in /Users/khorben/Projects/EdgeBSD/pkgsrc/bootstrap/work/pkg_install/lib
*** [all] Error code 1

bmake: stopped in /Users/khorben/Projects/EdgeBSD/pkgsrc/bootstrap/work/pkg_install
1 error

bmake: stopped in /Users/khorben/Projects/EdgeBSD/pkgsrc/bootstrap/work/pkg_install
===> exited with status 2
aborted.