Re: I want to merge some BLAS updates to get things in a future-proof shape before the branch. Please review.

To: Greg Troxel <gdt%lexort.com@localhost>
Subject: Re: I want to merge some BLAS updates to get things in a future-proof shape before the branch. Please review.
From: "Dr. Thomas Orgis" <thomas.orgis%uni-hamburg.de@localhost>
Date: Sat, 12 Jun 2021 09:13:32 +0200

Am Fri, 11 Jun 2021 08:20:11 -0400
schrieb Greg Troxel <gdt%lexort.com@localhost>: 

> > .include ../../mk/blas.buildlink3.mk
> >
> > The separte files would be mutually exclusive anyway.  
> 
> I would tend to one file, as two gives the impression it's more
> different than it is and perhaps should be usable in parallel.

OK, here it is … I'll merge it in tomorrow if noone objects or finds
more errors in it. Testing now if numpy picks up cblas from libopenblas.


Alrighty then,

Thomas

-- 
Dr. Thomas Orgis
HPC @ Universität Hamburg

# $NetBSD: blas.buildlink3.mk,v 1.1 2020/10/12 21:51:57 bacon Exp $
#
# This Makefile fragment is meant to be included by packages that use any
# BLAS (Basic Linear Algebra System) implementation instead of one particular
# one.
#
# Since pkgsrc always ships BLAS and LAPACK together (as upstream
# implementations do), this adds both BLAS_LIBS and LAPACK_LIBS to the linker
# flags.  Often, they will be identical or at least redundant. LAPACK_LIBS
# does include BLAS_LIBS, in any case.
#
# The C interfaces CBLAS and LAPACKE are also selected
# via BLAS_C_INTERFACE in the package and respective CBLAS_LIBS and
# LAPACKE_LIBS are set. Also, BLAS_INCLUDES is set to preprocessor
# flags to locate/use respective headers.
#
# Keywords: blas lapack netlib atlas openblas mkl
#
# === User-settable variables ===
#
# PKGSRC_BLAS_TYPES
#  This value specifies an exhaustive list of BLAS implementations we wish to
#  use in this pkgsrc installation, in descending order of preference.
#  The implementation selected for a build will be the first one in
#  PKGSRC_BLAS_TYPES that also appears in BLAS_ACCEPTED (see below).
#  Typically set in mk.conf.
#
#  Possible: one or more of netlib, openblas, openblas_pthread,
#    openblas_openmp, and maybe sometime Apple's accelerate.framework
#    (to come: Intel MKL, other external optimized builds)
#
#  Default: All currently supported implementations (${_BLAS_TYPES})
#
# === Package-settable variables ===
#
# BLAS_ACCEPTED
#   This is a list of blas packages that are compatible with the current
#   package. If not set, any BLAS implementation is OK.
#   Typically set in package Makefile.
#
# BLAS_C_INTERFACE
#   Set to yes if the package requires CBLAS or LAPACKE. This defines
#   BLAS_INCLUDES and pulls in additional packages for netlib. Optimized
#   implementations include the C interfaces in the main library anyway,
#   but you still have the effect on BLAS_INCLUDES.
#
# BLAS_INDEX64
#   Set to yes if the package wants to utilize 64 bit indices.
#
# === Variables automatically set here for use in package builds ===
# 
# BLAS_TYPE
#   This is the BLAS implementation chosen for a particular package build from
#   PKGSRC_BLAS_TYPES and BLAS_ACCEPTED.  If PKGSRC_BLAS_TYPES and
#   BLAS_ACCEPTED have no implementations in common, it defaults to none
#   and the build fails.
# BLAS_LIBS
#   Linker flags used for linking to BLAS library
# LAPACK_LIBS
#   Linker flags used for linking to LAPACK library
# CBLAS_LIBS
#   Linker flags used for linking to CBLAS library
# LAPACKE_LIBS
#   Linker flags used for linking to LAPACKE library
# BLAS_INCLUDES
#   Preprocessor flags to locate/use C interfaces

.if !defined(MK_BLAS_BUILDLINK3_MK)

MK_BLAS_BUILDLINK3_MK=

BUILD_DEFS+=		PKGSRC_BLAS_TYPES
BUILD_DEFS_EFFECTS+=	BLAS_TYPE BLAS_LIBS LAPACK_LIBS

.include "../../mk/bsd.prefs.mk"

# List of all possible BLAS choices, in order of *DEFAULT* preference.
# netlib is the reference implementation to which all others conform and
# should come first by default for maximum compatibility.  It is also the
# slowest and not desirable in many situations.  Users can override by setting
# PKGSRC_BLAS_TYPES. (See comment above)
_BLAS_TYPES=	netlib openblas openblas_pthread openblas_openmp
# TODO: Check if ILP64 is available from the framework
# Darwin
#.if exists(/System/Library/Frameworks/Accelerate.framework)
#_BLAS_TYPES+=	accelerate.framework
#.endif

BLAS_ACCEPTED?=	${_BLAS_TYPES}
PKGSRC_BLAS_TYPES?= ${_BLAS_TYPES}

_BLAS_MATCH=
.for b in ${PKGSRC_BLAS_TYPES}
_BLAS_MATCH+=	${BLAS_ACCEPTED:M${b}}
.endfor
.if !empty(_BLAS_MATCH)
BLAS_TYPE=	${_BLAS_MATCH:[1]}
.else
BLAS_TYPE=	none
.endif

.if !empty(BLAS_INDEX64:Myes)
_BLAS_64=	64
.else
_BLAS_64=
.endif

.if ${BLAS_TYPE} == "netlib"
_BLAS_PKGPATH=		wip/lapack${_BLAS_64}
_CBLAS_PKGPATH=		wip/cblas${_BLAS_64}
_LAPACKE_PKGPATH=	wip/lapacke${_BLAS_64}
BLAS_LIBS=	-lblas${_BLAS_64}
LAPACK_LIBS=	-llapack${_BLAS_64} ${BLAS_LIBS}
CBLAS_LIBS=	-lcblas${_BLAS_64} ${BLAS_LIBS}
LAPACKE_LIBS=	-llapacke${_BLAS_64} ${LAPACK_LIBS}
BLAS_INCLUDES=	-I${PREFIX}/include/netlib${_BLAS_64}
.  if ${_BLAS_64} == "64"
BLAS_INCLUDES+= -DWeirdNEC -DHAVE_LAPACK_CONFIG_H -DLAPACK_ILP64
.  endif
.elif ${BLAS_TYPE} == "openblas"
_BLAS_PKGPATH=	wip/openblas${_BLAS_64}
BLAS_LIBS=	-lopenblas${_BLAS_64}
LAPACK_LIBS=	${BLAS_LIBS}
CBLAS_LIBS=	${BLAS_LIBS}
LAPACKE_LIBS=	${BLAS_LIBS}
BLAS_INCLUDES=	-I${PREFIX}/include/openblas${_BLAS_64}
.elif ${BLAS_TYPE} == "openblas_pthread"
_BLAS_PKGPATH=	wip/openblas${_BLAS_64}_pthread
BLAS_LIBS=	-lopenblas${_BLAS_64}_pthread
LAPACK_LIBS=	${BLAS_LIBS}
CBLAS_LIBS=	${BLAS_LIBS}
LAPACKE_LIBS=	${BLAS_LIBS}
BLAS_INCLUDES=	-I${PREFIX}/include/openblas64_pthread
.elif ${BLAS_TYPE} == "openblas_openmp"
_BLAS_PKGPATH=	wip/openblas${_BLAS_64}_openmp
BLAS_LIBS=	-lopenblas${_BLAS_64}_openmp
LAPACK_LIBS=	${BLAS_LIBS}
CBLAS_LIBS=	${BLAS_LIBS}
LAPACKE_LIBS=	${BLAS_LIBS}
BLAS_INCLUDES=	-I${PREFIX}/include/openblas${_BLAS_64}_openmp
#.elif ${BLAS_TYPE} == "accelerate.framework"
#BLAS_LIBS=	-framework Accelerate
#LAPACK_LIBS=	${BLAS_LIBS}
.else # invalid or unimplemented type
PKG_FAIL_REASON+=	\
	"There is no acceptable BLAS for ${PKGNAME} in: ${PKGSRC_BLAS_TYPES}."
.endif

.if defined(_BLAS_PKGPATH)
.include "../../${_BLAS_PKGPATH}/buildlink3.mk"
.endif

.if !empty(BLAS_C_INTERFACE:Myes)
.  if defined(_CBLAS_PKGPATH)
.    include "../../${_CBLAS_PKGPATH}/buildlink3.mk"
.  endif
.  if defined(_LAPACKE_PKGPATH)
.    include "../../${_LAPACKE_PKGPATH}/buildlink3.mk"
.  endif
.else
.  undef	BLAS_INCLUDES
.endif

.endif # BLAS_BUILDLINK3_MK

Follow-Ups:
- Re: I want to merge some BLAS updates to get things in a future-proof shape before the branch. Please review.
  - From: nia

References:
- I want to merge some BLAS updates to get things in a future-proof shape before the branch. Please review.
  - From: Dr. Thomas Orgis
- Re: I want to merge some BLAS updates to get things in a future-proof shape before the branch. Please review.
  - From: Greg Troxel
- Re: I want to merge some BLAS updates to get things in a future-proof shape before the branch. Please review.
  - From: Dr. Thomas Orgis
- Re: I want to merge some BLAS updates to get things in a future-proof shape before the branch. Please review.
  - From: Greg Troxel

Prev by Date: Re: I want to merge some BLAS updates to get things in a future-proof shape before the branch. Please review.
Next by Date: Re: I want to merge some BLAS updates to get things in a future-proof shape before the branch. Please review.
Previous by Thread: Re: I want to merge some BLAS updates to get things in a future-proof shape before the branch. Please review.
Next by Thread: Re: I want to merge some BLAS updates to get things in a future-proof shape before the branch. Please review.
Indexes:

Home | Main Index | Thread Index | Old Index