64-bit atomic ops in net/bind916 (Re: CVS commit: pkgsrc/net/bind916)

[Rin Okuyama <rokuyama.rk%gmail.com@localhost>]

(cc: added to tech-pkg@)

On 2021/07/20 16:25, Thomas Klausner wrote:
> On Tue, Jul 20, 2021 at 06:39:45AM +0000, Rin Okuyama wrote:
> > Module Name:	pkgsrc
> > Committed By:	rin
> > Date:		Tue Jul 20 06:39:45 UTC 2021
> >
> > Modified Files:
> > 	pkgsrc/net/bind916: Makefile distinfo
> > 	pkgsrc/net/bind916/patches: patch-lib_dns_include_dns_zone.h
> > 	    patch-lib_dns_zone.c patch-lib_isc_stats.c
> > 	    patch-lib_ns_include_ns_client.h
> > Added Files:
> > 	pkgsrc/net/bind916/patches: patch-lib_isc_include_isc_types.h
> > 	    patch-lib_ns_client.c
> >
> > Log Message:
> > net/bind916 Use atomic 32-bit integers where appropriate, revision++
>
> This looks like a patch that should be sent upstream. Have you done that?

No.

I'm not sure whether upstream will accept this fix; for most other
OSes (?), 64-bit atomic ops are provided for ILP32 platforms by libc,
that we provide as devel/libatomic.

Also, I don't use this package personally, i.e., cannot fully test
this by myself.

If we want to reduce maintenance costs added by these patches, it may
be an option to remove these changes completely, and make this package
depended on devel/libatomic for ILP32 platforms.

Thanks,
rin