Adding gst-plugins1-good dependency to webkit-gtk before 2021Q4

[Leonardo Taccari <leot%NetBSD.org@localhost>]

Hello folks!
I am asking if I can commit the attached patch in this email during the
freeze. It should be pretty safe given that it only adds an extra
dependency but a double-check and okay is more than welcome!

I have noticed that webkit-gtk when a web page with audios/videos
elements was accessed crashed.

Looking at the backtrace (omitting extra parts probably not so
interesting):

[...]
Core was generated by `WebKitWebProcess'.
Program terminated with signal SIGABRT, Aborted.
#0  0x00007725737a405a in _lwp_kill () from /usr/lib/libc.so.12
[Current thread is 1 (process 2276)]
(gdb) bt
#0  0x00007725737a405a in _lwp_kill () from /usr/lib/libc.so.12
#1  0x00007725737a4500 in abort () at /usr/src/lib/libc/stdlib/abort.c:74
#2  0x000077257f116678 in WebCore::makeGStreamerElement(char const*, char const*) [clone .cold] () from /usr/pkg/lib/libwebkit2gtk-4.0.so.37
#3  0x000077257dac6e3e in WebCore::createAutoAudioSink(WTF::String const&) () from /usr/pkg/lib/libwebkit2gtk-4.0.so.37
#4  0x000077257ee9a7ca in WebCore::MediaPlayerPrivateGStreamer::createAudioSink() () from /usr/pkg/lib/libwebkit2gtk-4.0.so.37
#5  0x000077257ee9ad98 in WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer(WebCore::MediaPlayer*) () from /usr/pkg/lib/libwebkit2gtk-4.0.so.37
#6  0x000077257f99258b in WebCore::MediaPlayerFactoryGStreamer::createMediaEnginePlayer(WebCore::MediaPlayer*) const () from /usr/pkg/lib/libwebkit2gtk-4.0.so.37
#7  0x000077257ea2dc77 in WebCore::MediaPlayer::loadWithNextMediaEngine(WebCore::MediaPlayerFactory const*) () from /usr/pkg/lib/libwebkit2gtk-4.0.so.37
#8  0x000077257ea2e5c3 in WebCore::MediaPlayer::load(WTF::URL const&, WebCore::ContentType const&, WTF::String const&) () from /usr/pkg/lib/libwebkit2gtk-4.0.so.37
#9  0x000077257e636c65 in WebCore::HTMLMediaElement::loadResource(WTF::URL const&, WebCore::ContentType&, WTF::String const&) () from /usr/pkg/lib/libwebkit2gtk-4.0.so.37
[...]

Despite no debug symbols this is likely happening because
WebCore::createAutoAudioSink() needs `autoaudiosink' (created via
WebCore::makeGStreamerElement()) and WebCore::makeGStreamerElement() aborts
if it is not able to create it, in that case because gst-plugins1-good
is not installed.

The attached patch fixes this issue by adding gst-plugins1-good
as a dependency similarly to gst-plugins1-base. 

OK to commit it during the freeze?


Thank you!

webkit-gtk: Add a dependency to gst-plugins1-good

webkit-gtk now needs "autoaudiosink" plugin part of gst-plugins1-good
otherwise it aborts.

Bump PKGREVISION.

Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/www/webkit-gtk/Makefile,v
retrieving revision 1.217
diff -u -p -r1.217 Makefile
--- Makefile	20 Dec 2021 12:26:16 -0000	1.217
+++ Makefile	28 Dec 2021 15:43:11 -0000
@@ -2,6 +2,7 @@
 
 DISTNAME=	webkitgtk-2.34.3
 PKGNAME=	${DISTNAME:S/webkitgtk/webkit-gtk/}
+PKGREVISION=	1
 CATEGORIES=	www
 MASTER_SITES=	https://www.webkitgtk.org/releases/
 EXTRACT_SUFX=	.tar.xz
@@ -147,6 +148,7 @@ BUILDLINK_API_DEPENDS.gstreamer1+=	gstre
 .include "../../multimedia/gstreamer1/buildlink3.mk"
 BUILDLINK_API_DEPENDS.gst-plugins1-base+=	gst-plugins1-base>=1.0.3
 .include "../../multimedia/gst-plugins1-base/buildlink3.mk"
+.include "../../multimedia/gst-plugins1-good/buildlink3.mk"
 BUILDLINK_API_DEPENDS.libsoup+= libsoup>=2.42.2nb3
 .include "../../net/libsoup/buildlink3.mk"
 .include "../../security/libsecret/buildlink3.mk"
Index: buildlink3.mk
===================================================================
RCS file: /cvsroot/pkgsrc/www/webkit-gtk/buildlink3.mk,v
retrieving revision 1.85
diff -u -p -r1.85 buildlink3.mk
--- buildlink3.mk	8 Dec 2021 16:02:48 -0000	1.85
+++ buildlink3.mk	28 Dec 2021 15:43:11 -0000
@@ -28,6 +28,7 @@ pkgbase := webkit-gtk
 .include "../../graphics/libwebp/buildlink3.mk"
 .include "../../multimedia/gstreamer1/buildlink3.mk"
 .include "../../multimedia/gst-plugins1-base/buildlink3.mk"
+.include "../../multimedia/gst-plugins1-good/buildlink3.mk"
 .include "../../net/libsoup/buildlink3.mk"
 .include "../../security/libsecret/buildlink3.mk"
 .include "../../textproc/icu/buildlink3.mk"