Re: devel/gobject-introspection Makefile

[Thomas Klausner <wiz%NetBSD.org@localhost>]

On Wed, Feb 16, 2022 at 07:43:04AM -0700, Brook Milligan wrote:
> It seems that the Makefile for devel/gobject-introspection uses a non-standard option (-rm) for find, which is not supported on Darwin.
> 
> From the NetBSD find(1) man page: 
> 
> STANDARDS
> 
>      The find utility syntax is a superset of the syntax specified by the IEEE Std 1003.2 (``POSIX.2'') standard.
> 
>      The options, the -amin, -anewer, -asince, -cmin, -cnewer, -csince, -delete, -empty, -execdir, -follow, -fstype, -iname, -inum, -iregex, -links, -ls, -maxdepth, -mindepth, -mmin, -path, -print0, -printx, -regex, -rm, and -since primaries, and the -not operator are extensions to IEEE Std 1003.2 (``POSIX.2'').
> 
> The following patch fixes this.
> 
> --- a/devel/gobject-introspection/Makefile	Tue Feb 15 20:58:23 2022 -0700
> +++ b/devel/gobject-introspection/Makefile	Wed Feb 16 07:36:36 2022 -0700
> @@ -49,7 +49,7 @@
>  MAKE_ENV+=	GI_SCANNER_DISABLE_CACHE=yes
>  
>  post-install:
> -	cd ${DESTDIR}${PREFIX} && find . -name *.orig -rm
> +	cd ${DESTDIR}${PREFIX} && find . -name *.orig | xargs rm
>  
>  BUILDLINK_API_DEPENDS.glib2+= glib2>=2.58.0
>  .include "../../devel/glib2/buildlink3.mk”
> 
> Is there a better solution?

Another user already reported a problem with this on pkgsrc-changes, and it's now

${FIND} ${DESTDIR}${PREFIX} -name \*.orig -exec rm {} \;

which should hopefully work everywere.
 Thomas