Miscellaneous firefox issues

[John Klos <john%ziaspace.com@localhost>]

Just a few issues I'd like to share so I don't forget them:

www/firefox52 fails to install if you run "make package ; make install". I 
was going to do it again to paste the results of the failure here, but 
apparently www/firefox52 is currently broken in general:

/usr/pkgsrc/www/firefox52/work/firefox-52.9.0esr/db/sqlite3/src/sqlite3.c: 
In function 'sqlite3SelectNew.isra':
/usr/pkgsrc/www/firefox52/work/firefox-52.9.0esr/db/sqlite3/src/sqlite3.c:115935:10: 
warning: function may return address of local variable 
[-Wreturn-local-addr]
115935 |   return pNew;
       |          ^~~~
/usr/pkgsrc/www/firefox52/work/firefox-52.9.0esr/db/sqlite3/src/sqlite3.c:115895:10: 
note: declared here
115895 |   Select standin;
       |          ^~~~~~~
libtoolkit_components_places.a.desc
rm -f libtoolkit_components_places.a
/usr/pkgsrc/www/firefox52/work/build/_virtualenv/bin/python 
/usr/pkgsrc/www/firefox52/work/firefox-52.9.0esr/config/expandlibs_gen.py 
-o libtoolkit_components_places.a.desc Unified_cpp_components_places0.o
gmake[3]: Leaving directory 
'/usr/pkgsrc/www/firefox52/work/build/toolkit/components/places'
libdb_sqlite3_src.a.desc
rm -f libdb_sqlite3_src.a
/usr/pkgsrc/www/firefox52/work/build/_virtualenv/bin/python 
/usr/pkgsrc/www/firefox52/work/firefox-52.9.0esr/config/expandlibs_gen.py 
-o libdb_sqlite3_src.a.desc sqlite3.o
gmake[3]: Leaving directory 
'/usr/pkgsrc/www/firefox52/work/build/db/sqlite3/src'
gmake[2]: Leaving directory '/usr/pkgsrc/www/firefox52/work/build'
gmake[1]: *** 
[/usr/pkgsrc/www/firefox52/work/firefox-52.9.0esr/config/recurse.mk:33: 
compile] Error 2
gmake[1]: Leaving directory '/usr/pkgsrc/www/firefox52/work/build'
gmake: *** 
[/usr/pkgsrc/www/firefox52/work/firefox-52.9.0esr/config/rules.mk:523: 
all] Error 2
*** Error code 2



www/firefox (102.0) fails on NetBSD-9.99.98 on aarch64:

/usr/pkgsrc/www/firefox/work/.cwrapper/bin/c++ -std=gnu++17 
-U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong 
-DPNG_NO_ASSEMBLER_CODE -I/usr/local/include -I/usr/include 
-I/usr/local/include/nspr -I/usr/X11R7/include -I/usr/X11R7/include/libdrm 
-I/usr/local/include/glib-2.0 -I/usr/local/include/gio-unix-2.0 
-I/usr/local/lib/glib-2.0/include -I/usr/local/include/ffmpeg5 
-I/usr/X11R7/include/freetype2 -I/usr/local/include/harfbuzz -Wall 
-Wempty-body -Wignored-qualifiers -Wpointer-arith -Wsign-compare 
-Wtype-limits -Wunreachable-code -Wno-invalid-offsetof -Wc++2a-compat 
-Wduplicated-cond -Wimplicit-fallthrough -Wno-error=maybe-uninitialized 
-Wno-error=deprecated-declarations -Wno-error=array-bounds 
-Wno-error=coverage-mismatch -Wno-error=free-nonheap-object 
-Wno-multistatement-macros -Wno-error=class-memaccess 
-Wno-error=deprecated-copy -Wformat -Wformat-overflow=2 -Wno-psabi 
-fno-sized-deallocation -fno-aligned-new -O2 
-D_GLIBCXX_INCLUDE_NEXT_C_HEADERS -fPIC -D_FORTIFY_SOURCE=2 
-I/usr/local/include -I/usr/include -I/usr/local/include/nspr 
-I/usr/X11R7/include -I/usr/X11R7/include/libdrm 
-I/usr/local/include/glib-2.0 -I/usr/local/include/gio-unix-2.0 
-I/usr/local/lib/glib-2.0/include -I/usr/local/include/ffmpeg5 
-I/usr/X11R7/include/freetype2 -I/usr/local/include/harfbuzz 
-fno-exceptions -Dunix -fPIC -DPIC -fno-rtti -ffunction-sections 
-fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -O2 
-fomit-frame-pointer -funwind-tables  -shared -Wl,--gc-sections 
-Wl,-soname,libxul.so -o libxul.so 
/usr/pkgsrc/www/firefox/work/build/toolkit/library/build/libxul_so.list 
-lpthread -Wl,-R/usr/local/lib/firefox -Wl,-R/usr/local/lib -Wl,-zrelro 
-L/usr/local/lib -L/usr/lib -Wl,-R/usr/lib -L/usr/local/lib/nspr 
-Wl,-R/usr/local/lib/nspr -L/usr/local/lib/nss -Wl,-R/usr/local/lib/nss 
-L/usr/X11R7/lib -Wl,-R/usr/X11R7/lib -L/usr/local/lib/ffmpeg5 
-Wl,-R/usr/local/lib/ffmpeg5 -Wl,-z,noexecstack -Wl,-z,text -Wl,-z,relro 
-Wl,-z,nocopyreloc -Wl,-Bsymbolic-functions -Wl,--build-id=sha1 
-fstack-protector-strong 
-Wl,-rpath-link,/usr/pkgsrc/www/firefox/work/build/dist/bin 
-Wl,-rpath-link,/usr/local/lib  ../../../js/src/build/libjs_static.a 
/usr/pkgsrc/www/firefox/work/build/aarch64-unknown-netbsd/release/libgkrust.a 
../../../config/external/lgpllibs/liblgpllibs.so 
../../../config/external/sqlite/libmozsqlite3.so 
../../../widget/gtk/mozgtk/libmozgtk.so   -L/usr/local/lib -licui18n 
-Wl,-R/usr/local/lib -licuuc -licudata -lrt -lm -ldl -lpthread -lffi 
-L/usr/local/lib/nspr -Wl,-R/usr/local/lib/nspr -lplds4 -lplc4 -lnspr4 -lz 
-Wl,-R/usr/local/lib/nss -L/usr/local/lib/nss -lssl3 -lsmime3 -lnss3 
-lnssutil3 -Wl,-rpath,/usr/X11R7/lib -L/usr/X11R7/lib -lfreetype -lbz2 
-lfontconfig -lgtk-3 -lgdk-3 -lpangocairo-1.0 -lpango-1.0 -lharfbuzz 
-latk-1.0 -lcairo-gobject -lcairo -lgdk_pixbuf-2.0 -lgio-2.0 -lgobject-2.0 
-lglib-2.0 -lintl -lwebpdemux -lwebp -Wl,-R/usr/lib -levent -lpixman-1 
-ldbus-glib-1 -ldbus-1 -lxcb-shm -lX11-xcb -lX11 -lxcb -lXext -lXrandr 
-lXcomposite -lXcursor -lXdamage -lXfixes -lXi -lXtst
ld: 
../../../third_party/libwebrtc/common_audio/common_audio_c_gn/Unified_c_common_audio_c_gn1.o:(.data.rel.ro.local.WebRtcSpl_CrossCorrelation+0x0): 
undefined reference to `WebRtcSpl_CrossCorrelationNeon'
ld: 
../../../third_party/libwebrtc/common_audio/common_audio_c_gn/Unified_c_common_audio_c_gn1.o:(.data.rel.ro.local.WebRtcSpl_DownsampleFast+0x0): 
undefined reference to `WebRtcSpl_DownsampleFastNeon'
ld: 
../../../third_party/libwebrtc/common_audio/common_audio_c_gn/Unified_c_common_audio_c_gn1.o:(.data.rel.ro.local.WebRtcSpl_MaxAbsValueW16+0x0): 
undefined reference to `WebRtcSpl_MaxAbsValueW16Neon'
ld: 
../../../third_party/libwebrtc/common_audio/common_audio_c_gn/Unified_c_common_audio_c_gn1.o:(.data.rel.ro.local.WebRtcSpl_MaxAbsValueW32+0x0): 
undefined reference to `WebRtcSpl_MaxAbsValueW32Neon'
ld: 
../../../third_party/libwebrtc/common_audio/common_audio_c_gn/Unified_c_common_audio_c_gn1.o:(.data.rel.ro.local.WebRtcSpl_MaxValueW32+0x0): 
undefined reference to `WebRtcSpl_MaxValueW32Neon'
ld: 
../../../third_party/libwebrtc/common_audio/common_audio_gn/Unified_cpp_common_audio_gn0.o: 
in function `webrtc::SincResampler::SincResampler(double, unsigned long, 
webrtc::SincResamplerCallback*)':
Unified_cpp_common_audio_gn0.cpp:(.text._ZN6webrtc13SincResamplerC2EdmPNS_21SincResamplerCallbackE+0x78): 
undefined reference to `webrtc::SincResampler::Convolve_NEON(float const*, 
float const*, float const*, double)'
ld: 
Unified_cpp_common_audio_gn0.cpp:(.text._ZN6webrtc13SincResamplerC2EdmPNS_21SincResamplerCallbackE+0x7c): 
undefined reference to `webrtc::SincResampler::Convolve_NEON(float const*, 
float const*, float const*, double)'
ld: 
../../../third_party/libwebrtc/common_audio/fir_filter_factory_gn/Unified_cpp_ir_filter_factory_gn0.o: 
in function `webrtc::CreateFirFilter(float const*, unsigned long, unsigned 
long)':
Unified_cpp_ir_filter_factory_gn0.cpp:(.text._ZN6webrtc15CreateFirFilterEPKfmm+0x44): 
undefined reference to `webrtc::FIRFilterNEON::FIRFilterNEON(float const*, 
unsigned long, unsigned long)'
ld: libxul.so: hidden symbol `WebRtcSpl_CrossCorrelationNeon' isn't 
defined
ld: final link failed: bad value
gmake[3]: *** 
[/usr/pkgsrc/www/firefox/work/firefox-102.0/config/rules.mk:531: 
libxul.so] Error 1
gmake[3]: Leaving directory 
'/usr/pkgsrc/www/firefox/work/build/toolkit/library/build'
gmake[2]: *** 
[/usr/pkgsrc/www/firefox/work/firefox-102.0/config/recurse.mk:72: 
toolkit/library/build/target] Error 2
gmake[2]: Leaving directory '/usr/pkgsrc/www/firefox/work/build'
gmake[1]: *** 
[/usr/pkgsrc/www/firefox/work/firefox-102.0/config/recurse.mk:34: compile] 
Error 2
gmake[1]: Leaving directory '/usr/pkgsrc/www/firefox/work/build'
gmake: *** 
[/usr/pkgsrc/www/firefox/work/firefox-102.0/config/rules.mk:352: all] 
Error 2
*** Error code 2

Stop.



Neither has any special options aside from preferring Python 3.10. Anyone?

Thanks,
John