Re: Builtin iconv not found on Darwin 21.6.0

[Frédéric Fauberteau <triaxx%NetBSD.org@localhost>]

> Le 25 sept. 2022 à 17:00, Jonathan Perkin <jperkin%mnx.io@localhost> a écrit :
> 
> * On 2022-09-25 at 13:24 BST, Frédéric Fauberteau wrote:
> 
>> As result of searching libiconv in libraries (among others):
>> % find /Library -name "*iconv*"
>> /Library/Developer/CommandLineTools/SDKs/MacOSX12.3.sdk/usr/include/iconv.h
>> /Library/Developer/CommandLineTools/SDKs/MacOSX12.3.sdk/usr/lib/libiconv.2.4.0.tbd
>> /Library/Developer/CommandLineTools/SDKs/MacOSX12.3.sdk/usr/lib/libiconv.2.tbd
>> /Library/Developer/CommandLineTools/SDKs/MacOSX12.3.sdk/usr/lib/libiconv.tbd
>> 
>> I think maybe BUILDINK_FIND_LIBS is misled by the tbd files…
> 
> We can no longer use native on macOS at all since they got rid of shared libraries.  You need to bootstrap with --prefer-pkgsrc=yes.
> 
>> I can fix it with this patch:
> 
> I think we're missing a patch in bootstrap to force PREFER_PKGSRC on newer macOS, rather than adding overrides for everything, similar to how OpenBSD and some Linux are handled.

I don't know from which version the shared libraries discontinued.

Index: bootstrap
===================================================================
RCS file: /cvsroot/pkgsrc/bootstrap/bootstrap,v
retrieving revision 1.315
diff -r1.315 bootstrap
626a627,631
> 	# New versions of MacOS get rid of shared libraries.
> 	if [ $macos_version -ge XXXX ]; then
> 		prefer_pkgsrc=yes
> 	fi
> 
633a639
>