bin-install and non-default python failing

[Greg Troxel <gdt%lexort.com@localhost>]

I have, otherwise without problems:

  netbsd-9 amd64 with pkgsrc-2023Q2 as a domU pkg build server

  BINPKG_SITES=           # do not fetch packages for bin-install
  DEPENDS_TARGET=         bin-install clean
  PKGSRC_KEEP_BIN_PKGS=   yes

I use bin-install because I often do 'pkgin ar' and don't want to
rebuild when I have a binary.  (Yes, I know this is a little bit like
pbulk.)

Generally this works fine.  However, I am trying to build
py311-virtualenv (because Home Assistant 2023.8.0 requires 3.11, which
is a mild clue on another subject), and I get a failure installing a
dependency of virtualenv (I had already built python311 uneventfully).

Lots of py310 stuff is installed, including virtualenv and dependencies.

It appears that bin-install is not really respecting
PYTHON_VERSION_REQD.  I wonder if this is a known bug, if anyone has
seen it or can reproduce, etc.

The problem seems to be in mk/install/bin-install.mk:

         found=`${PKG_BEST_EXISTS} "${PKGWILDCARD}" || ${TRUE}`;

but

  $ make PYTHON_VERSION_REQD=311 show-var VARNAME=PKGWILDCARD
  py311-hatch-vcs-[0-9]*

so py310-hatch-vcs should not match.  However PKGWILDCARD is py310 when
this is evaluated, found out by adding an echo line just before.  If I
use show-var, I get py311.

So I think the issue is failing to evaluate the python version logic
before this variable is set.

Any clues on how to fix?


----------------------------------------

  n9-amd64 gdt 14 /usr/pkgsrc/devel/py-virtualenv > make PYTHON_VERSION_REQD=311 package-install clean
  => Bootstrap dependency digest>=20211023: found digest-20220214
  => Checksum BLAKE2s OK for virtualenv-20.23.0.tar.gz
  => Checksum SHA512 OK for virtualenv-20.23.0.tar.gz
  ===> Installing dependencies for py311-virtualenv-20.23.0nb1
  ==========================================================================
  The following variables will affect the build process of this package,
  py311-virtualenv-20.23.0nb1.  Their current value is shown below:

          * PYTHON_VERSION_DEFAULT = 310

  Based on these variables, the following variables have been set:

          * PYPACKAGE = python311

  You may want to abort the process now with CTRL-C and change the value
  of variables in the first group before continuing.  Be sure to run
  `/usr/bin/make clean' after the changes.
  ==========================================================================
  => Tool dependency py311-hatch-vcs>=0.3: NOT found
  => Verifying bin-install clean for ../../devel/py-hatch-vcs
  ===> Binary install for py311-hatch-vcs>=0.3
  => Becoming ``root'' to make su-do-bin-install (sudo)
  ERROR: py310-hatch-vcs-0.3.0 is already installed - perhaps an older version?
  ERROR: If so, you may wish to ``pkg_delete py310-hatch-vcs-0.3.0'' and install
  ERROR: this package again by ``/usr/bin/make bin-install'' to upgrade it properly.
  *** Error code 1

  Stop.
  make: stopped in /nfs/pkgsrc/devel/py-hatch-vcs
  *** Error code 1

  Stop.
  make[1]: stopped in /nfs/pkgsrc/devel/py-hatch-vcs
  *** Error code 1

  Stop.
  make: stopped in /usr/pkgsrc/devel/py-virtualenv

----------------------------------------

  n9-amd64 gdt 21 /usr/pkgsrc/devel/py-hatch-vcs > make PYTHON_VERSION_REQD=311 bin-install
  ===> Binary install for py311-hatch-vcs-0.3.0
  => Becoming ``root'' to make su-do-bin-install (sudo)
  ERROR: py310-hatch-vcs-0.3.0 is already installed - perhaps an older version?
  ERROR: If so, you may wish to ``pkg_delete py310-hatch-vcs-0.3.0'' and install
  ERROR: this package again by ``/usr/bin/make bin-install'' to upgrade it properly.
  *** Error code 1

  Stop.
  make: stopped in /nfs/pkgsrc/devel/py-hatch-vcs
  *** Error code 1

  Stop.
  make: stopped in /usr/pkgsrc/devel/py-hatch-vcs

  n9-amd64 gdt 22 /usr/pkgsrc/devel/py-hatch-vcs > make PYTHON_VERSION_REQD=311 show-var VARNAME=PKGNAME
  py311-hatch-vcs-0.3.0

----------------------------------------