ocaml-cairo build failure

[Greg Troxel <gdt%lexort.com@localhost>]

ocaml-cairo fails to build, and the issue seems to start with something
(that I can't find, perhaps in dune land) trying to be clever about
pkg-config instead of just running it.  I have appended the full log,
but I think the essence is:

  (cd _build/default/src && ../config/discover.exe)
  which: /tmp/work/graphics/ocaml-cairo/work/.tools/bin/pkg-config
  -> not found

This leads to not finding the .h, and if I patch in a path to
discover.ml, then it finds that and fails on ft2.

Do you have any clues about where the 'which' is, and if this is causing
other problems?

Thanks,
Greg


=> Bootstrap dependency digest>=20211023: found digest-20220214
=> Checksum BLAKE2s OK for ocaml-cairo-0.6.4.tar.gz
=> Checksum SHA512 OK for ocaml-cairo-0.6.4.tar.gz
work -> /tmp/work/graphics/ocaml-cairo/work
===> Installing dependencies for ocaml-cairo-0.6.4nb8
==========================================================================
The supported build options for ocaml-cairo are:

	gtk pango

You can select which build options to use by setting PKG_DEFAULT_OPTIONS
or the following variable.  Its current value is shown:

	PKG_OPTIONS.ocaml-cairo (not defined)

==========================================================================
==========================================================================
The following variables will affect the build process of this package,
ocaml-cairo-0.6.4nb8.  Their current value is shown below:

        * OCAML_USE_OPT_COMPILER = yes

Based on these variables, the following variables have been set:

        * TERMCAP_TYPE = termcap

You may want to abort the process now with CTRL-C and change the value
of variables in the first group before continuing.  Be sure to run
`/usr/bin/make clean' after the changes.
==========================================================================
=> Tool dependency glib2-tools-[0-9]*: found glib2-tools-2.78.1
=> Tool dependency mktools-[0-9]*: found mktools-20220614
=> Tool dependency pkgconf-[0-9]*: found pkgconf-2.0.3
=> Tool dependency ccache-[0-9]*: found ccache-4.9
=> Tool dependency cwrappers>=20150314: found cwrappers-20220403
=> Tool dependency checkperms>=1.1: found checkperms-1.12
=> Build dependency x11-links>=1.35: found x11-links-1.35nb1
=> Build dependency ocaml-opaline>=0.3.3nb1: found ocaml-opaline-0.3.3nb1
=> Full dependency ocaml-dune>=3.11.1: found ocaml-dune-3.11.1
=> Full dependency ocaml-findlib>=1.9.3nb1: found ocaml-findlib-1.9.6
=> Full dependency ocaml>=4.14.0: found ocaml-4.14.1
=> Full dependency cairo>=1.18.0: found cairo-1.18.0nb1
=> Full dependency ocaml-dune-configurator>=3.11.1: found ocaml-dune-configurator-3.11.1
===> Checking for vulnerabilities in ocaml-cairo-0.6.4nb8
===> Overriding tools for ocaml-cairo-0.6.4nb8
===> Extracting for ocaml-cairo-0.6.4nb8
===> Patching for ocaml-cairo-0.6.4nb8
===> Creating toolchain wrappers for ocaml-cairo-0.6.4nb8
===> Configuring for ocaml-cairo-0.6.4nb8
=> Generating pkg-config file for builtin expat package.
=> Checking for portability problems in extracted files
===> Building for ocaml-cairo-0.6.4nb8
File "src/dune", line 12, characters 0-132:
12 | (rule
13 |  (targets c_flags.sexp c_library_flags.sexp cairo_ocaml.h)
14 |  (deps    cairo_ocaml.h.p)
15 |  (action  (run ../config/discover.exe)))
(cd _build/default/src && ../config/discover.exe)
which: /tmp/work/graphics/ocaml-cairo/work/.tools/bin/pkg-config
-> not found
compiling c program:
 | #include <stdio.h>
 | #include <cairo.h>
 | 
 | 
 | #define DUNE_ABS(x) ((x >= 0)? x: -(x))
 | #define DUNE_D0(x) ('0'+(DUNE_ABS(x)/1         )%10)
 | #define DUNE_D1(x) ('0'+(DUNE_ABS(x)/10        )%10), DUNE_D0(x)
 | #define DUNE_D2(x) ('0'+(DUNE_ABS(x)/100       )%10), DUNE_D1(x)
 | #define DUNE_D3(x) ('0'+(DUNE_ABS(x)/1000      )%10), DUNE_D2(x)
 | #define DUNE_D4(x) ('0'+(DUNE_ABS(x)/10000     )%10), DUNE_D3(x)
 | #define DUNE_D5(x) ('0'+(DUNE_ABS(x)/100000    )%10), DUNE_D4(x)
 | #define DUNE_D6(x) ('0'+(DUNE_ABS(x)/1000000   )%10), DUNE_D5(x)
 | #define DUNE_D7(x) ('0'+(DUNE_ABS(x)/10000000  )%10), DUNE_D6(x)
 | #define DUNE_D8(x) ('0'+(DUNE_ABS(x)/100000000 )%10), DUNE_D7(x)
 | #define DUNE_D9(x) ('0'+(DUNE_ABS(x)/1000000000)%10), DUNE_D8(x)
 | #define DUNE_SIGN(x) ((x >= 0)? '0': '-')
 | 
 | 
 | const char s0[] = {
 |   'B', 'E', 'G', 'I', 'N', '-', '0', '-',
 |   DUNE_SIGN((CAIRO_VERSION_MAJOR)),
 |   DUNE_D9((CAIRO_VERSION_MAJOR)),
 |   '-', 'E', 'N', 'D'
 | };
 | 
 | 
 | const char s1[] = {
 |   'B', 'E', 'G', 'I', 'N', '-', '1', '-',
 |   DUNE_SIGN((CAIRO_VERSION_MINOR)),
 |   DUNE_D9((CAIRO_VERSION_MINOR)),
 |   '-', 'E', 'N', 'D'
 | };
 | 
run: gcc -O2 -fno-strict-aliasing -fwrapv  -pthread  -fPIC -O2 -I/usr/include -I/usr/include/cairo -I /usr/pkg/lib/ocaml -o /tmp/build_92d90d_dune/ocaml-configuratorc3be5c/c-test-0/test.o -c /tmp/build_92d90d_dune/ocaml-configuratorc3be5c/c-test-0/test.c -lm
-> process exited with code 1
-> stdout:
-> stderr:
 | /tmp/build_92d90d_dune/ocaml-configuratorc3be5c/c-test-0/test.c:2:10: fatal error: cairo.h: No such file or directory
 |     2 | #include <cairo.h>
 |       |          ^~~~~~~~~
 | compilation terminated.
Error: failed to compile program
*** Error code 1

Stop.
make[1]: stopped in /n0/gdt/pkgsrc-current/pkgsrc/graphics/ocaml-cairo
*** Error code 1

Stop.
make: stopped in /usr/pkgsrc/graphics/ocaml-cairo