Re: reproducible firefox build failure on NetBSD 10.99.10 amd64

[Niclas Rosenvik <nros%netbsd.org@localhost>]

Hi check js/src/zydis/Zycore/Defines.h in the firefox sources.

Change the line:
#elif defined(__unix)
to:
#elif defined(__unix) || defined(__unix__)

NetBSD does not define __unix but __unix__
so it is considered an unsupported OS.

I don't want to commit a fix for this in pkgsrc
since doing so means building rust, and that is
slow and takes a long time on NetBSD 9.

I have filed a fix for this on Zycore:s
issue tracker on Github.

/Niclas

On Fri, 19 Jan 2024 22:08:22 +0100
Nikita Ronja Gillmann <nikita%netbsd.org@localhost> wrote:

> Nikita Ronja Gillmann transcribed 3.9K bytes:
> >I'm getting the error below in pbulk on NetBSD amd64 10.99.10.
> >I'm considering rebuilding all the packages to see if something
> >failed to build correctly, or just start with a new cvs checkout (I
> >already cleaned it up enough before this)..
> >Has anyone run into this before?
> 
> Same issue with a new cvs checkout, a clean chroot, and building the 
> entire pbulk again:
> 
> gmake[3]: Entering directory '/tmp/work/build/js/src/zydis'
> mkdir -p '.deps/'
> /tmp/work/.cwrapper/bin/gcc -std=gnu99 -o Memory.o -c
> -I/tmp/work/build/dist/system_wrappers -include
> /tmp/work/firefox-121.0.1/config/gcc_hidden.h
> -fstack-protector-strong -DDEBUG=1 -DWASM_SUPPORTS_HUGE_MEMORY
> -DJS_CACHEIR_SPEW -DJS_STRU CTURED_SPEW -DJS_HAS_CTYPES
> -DEXPORT_JS_API -DMOZ_HAS_MOZGLUE
> -I/tmp/work/firefox-121.0.1/js/src/zydis
> -I/tmp/work/build/js/src/zydis -I/tmp/work/build/js/src
> -I/tmp/work/firefox-121.0.1/js/src -I/tmp/work/build/dist/include
> -I/usr/pkg/inc lude/nspr -I/usr/pkg/include/nss
> -I/usr/pkg/include/nspr -I/tmp/work/build/dist/include/nss
> -I/usr/X11R7/include/pixman-1 -I/usr/pkg/include -include
> /tmp/work/build/js/src/js-confdefs.h -DMOZILLA_CLIENT
> -I/usr/pkg/include -I/usr/include - I/usr/pkg/include/nspr
> -I/usr/X11R7/include -I/usr/X11R7/include/libdrm
> -I/usr/pkg/include/glib-2.0 -I/usr/pkg/include/gio-unix-2.0
> -I/usr/pkg/lib/glib-2.0/include -I/usr/pkg/include/ffmpeg6
> -I/usr/pkg/include/freetype2 -I/usr/pkg/include/ harfbuzz -O2
> -D_GLIBCXX_INCLUDE_NEXT_C_HEADERS -msse2 -D__LOCALE_C_ONLY
> -I/usr/pkg/include -I/usr/include -I/usr/pkg/include/nspr
> -I/usr/X11R7/include -I/usr/X11R7/include/libdrm
> -I/usr/pkg/include/glib-2.0 -I/usr/pkg/include/gio-unix-2.0
> -I/usr/pkg/lib/glib-2.0/include -I/usr/pkg/include/ffmpeg6
> -I/usr/pkg/include/freetype2 -I/usr/pkg/include/harfbuzz -Dunix -fPIC
> -DPIC -ffunction-sections -fdata-sections -fno-math-errno -pthread
> -pipe -g -Og -fno-omit-frame-pointer -funwi nd-tables -Wall
> -Wempty-body -Wignored-qualifiers -Wpointer-arith -Wsign-compare
> -Wtype-limits -Wunreachable-code -Wduplicated-cond -Wlogical-op
> -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations
> -Wno-error=array-bounds -Wno -error=free-nonheap-object
> -Wno-multistatement-macros -Wno-error=class-memaccess -Wformat
> -Wformat-overflow=2 -Werror=implicit-function-declaration -Wno-psabi
> -Wno-error=builtin-macro-redefined -fno-strict-aliasing
> -ffp-contract=off  -MD - MP -MF .deps/Memory.o.pp
> /tmp/work/firefox-121.0.1/js/src/zydis/Zycore/API/Memory.c In file
> included from
> /tmp/work/firefox-121.0.1/js/src/zydis/Zycore/API/Memory.c:27:
> /tmp/work/firefox-121.0.1/js/src/zydis/Zycore/API/Memory.h:46:5:
> error: #error "Unsupported platform detected" 46 | #   error
> "Unsupported platform detected" |     ^~~~~
> /tmp/work/firefox-121.0.1/js/src/zydis/Zycore/API/Memory.h:75:1:
> error: empty enum is invalid 75 | } ZyanMemoryPageProtection; | ^
> /tmp/work/firefox-121.0.1/js/src/zydis/Zycore/API/Memory.h:119:5:
> error: unknown type name 'ZyanMemoryPageProtection' 119 |
> ZyanMemoryPageProtection protection); |     ^~~~~~~~~~~~~~~~~~~~~~~~
> /tmp/work/firefox-121.0.1/js/src/zydis/Zycore/API/Memory.c:36:5:
> error: #error "Unsupported platform detected" 36 | #   error
> "Unsupported platform detected" |     ^~~~~
> /tmp/work/firefox-121.0.1/js/src/zydis/Zycore/API/Memory.c:84:5:
> error: unknown type name 'ZyanMemoryPageProtection' 84 |
> ZyanMemoryPageProtection protection) |     ^~~~~~~~~~~~~~~~~~~~~~~~
> /tmp/work/firefox-121.0.1/js/src/zydis/Zycore/API/Memory.c: In
> function 'ZyanMemoryGetSystemPageSize':
> /tmp/work/firefox-121.0.1/js/src/zydis/Zycore/API/Memory.c:61:1:
> warning: control reaches end of non-void function [-Wreturn-type] 61
> | } | ^ /tmp/work/firefox-121.0.1/js/src/zydis/Zycore/API/Memory.c:
> In function 'ZyanMemoryGetSystemAllocationGranularity':
> /tmp/work/firefox-121.0.1/js/src/zydis/Zycore/API/Memory.c:77:1:
> warning: control reaches end of non-void function [-Wreturn-type] 77
> | } | ^ gmake[3]: *** [/tmp/work/firefox-121.0.1/config/rules.mk:600:
> Memory.o] Error 1 gmake[3]: Leaving directory
> '/tmp/work/build/js/src/zydis' gmake[2]: ***
> [/tmp/work/firefox-121.0.1/config/recurse.mk:72:
> js/src/zydis/target-objects] Error 2 gmake[2]: *** Waiting for
> unfinished jobs....
> 
> </svg>