Re: [SORRY] I broke python311 and other packages

[Jonathan Perkin <jperkin%mnx.io@localhost>]

* On 2024-05-02 at 10:30 BST, Jonathan Perkin wrote:

> In particular, it completely removes ncursesw support, which is what 
> causes the bug here.  The curses module checks for ncurses extended 
> colour functions and enables them if new enough, but because of our 
> patch it ends up linking against libncurses instead which does not 
> contain those functions.

I have a fix for this, but it's going to require some more extensive 
testing.  The basics are that I patch setup.py so that:

	curses_library = "@CURSES_TYPE@"

and that gets SUBST to the correct string.  This fixes the build on 
macOS and Linux.

However!  That then breaks the build on SmartOS, which was working ok 
previously.  This is due to the mess we have in the buildlink3.mk files 
for ncurses and ncursesw, where:

 - ncurses specifies BUILDLINK_INCDIRS but ncursesw does not

 - adding BUILDLINK_INCDIRS to ncursesw partly solves the problem...

 - ...but then breaks because for some reason ncursesw includes ncurses 
   buildlink3.mk, and include/ncurses ends up before include/ncursesw,
   so the wrong includes end up used and the build fails.

There's already a bunch of broken code in these files I'm testing in:

  https://github.com/TritonDataCenter/pkgsrc/commit/7a2f913930a2b8cf6864ed2af5d3ec3c4ec77e62

but I'm going to also have to perform bulk builds to see what breaks if 
I remove the ncurses/buildlink3.mk include from ncursesw.

Also note that PKG_OPTIONS=-readline doesn't actually work, as the 
readline module is still built (I don't recall which OS this happens 
on).

--
Jonathan Perkin   -   mnx.io   -   pkgsrc.smartos.org
Open Source Complete Cloud   www.tritondatacenter.com