Re: CVS commit: pkgsrc/x11/qt5-qtbase

[Greg Troxel <gdt%lexort.com@localhost>]

Ryo ONODERA <ryo%tetera.org@localhost> writes:

> Greg Troxel <gdt%lexort.com@localhost> writes:
>
>> "Ryo ONODERA" <ryoon%netbsd.org@localhost> writes:
>>
>>> Module Name:	pkgsrc
>>> Committed By:	ryoon
>>> Date:		Thu May 30 06:39:50 UTC 2024
>>>
>>> Modified Files:
>>> 	pkgsrc/x11/qt5-qtbase: Makefile.common
>>>
>>> Log Message:
>>> qt5: Force gnu++17 for the latest textproc/icu
>>>
>>> * Fix an icu-related error in configure stage.
>>
>> If icu requires gnu++17 then presumably it probably should be setting
>> that in bl3 (plus it's broken but I know that isn't going to change :-)
>> rather than setting FORCE_CXX_STD in using packages.
>
> Some direct consumers of textproc/icu, for example www/firefox and
> misc/libreoffice, dislike FORCE_CXX_STD because they use multiple -std=
> options in one package.
>
> Defining FORCE_CXX_STD in textproc/icu/buildlink3.mk will break
> their builds.

I can see then that it has to be.  It would be great if someone added
icu/bl3 comments to explain this, because it is far from obvious.