Re: CVS commit: pkgsrc/x11/qt5-qtbase

[Ryo ONODERA <ryo%tetera.org@localhost>]

Hi,

Some dependencies of misc/libreoffice including fonts/harfbuzz-icu require the similar things.

misc/libreoffice itself requires relatively big patch for ICU 75 and I will commit the fixes tonight hopefully.

As far as I remember correctly, x11/qt5-qtbase has alloca() problem when -std=c++NN is specified.

ICU itself may be safe for -std=c++NN, however it may be not safe totally.

--
Ryo ONODERA // ryo%tetera.org@localhost
PGP fingerprint = 82A2 DC91 76E0 A10A 8ABB  FD1B F404 27FA C7D1 15F3

On Fri, May 31, 2024 at 19:20 Patrick Welche <prlw1%welche.eu@localhost> wrote:

On Thu, May 30, 2024 at 11:17:52PM +0900, Ryo ONODERA wrote:
> Hi,
>
> Greg Troxel <gdt%lexort.com@localhost> writes:
>
> > "Ryo ONODERA" <ryoon%netbsd.org@localhost> writes:
> >
> >> Module Name:       pkgsrc
> >> Committed By:      ryoon
> >> Date:              Thu May 30 06:39:50 UTC 2024
> >>
> >> Modified Files:
> >>    pkgsrc/x11/qt5-qtbase: Makefile.common
> >>
> >> Log Message:
> >> qt5: Force gnu++17 for the latest textproc/icu
> >>
> >> * Fix an icu-related error in configure stage.
> >
> > If icu requires gnu++17 then presumably it probably should be setting
> > that in bl3 (plus it's broken but I know that isn't going to change :-)
> > rather than setting FORCE_CXX_STD in using packages.
>
> Some direct consumers of textproc/icu, for example www/firefox and
> misc/libreoffice, dislike FORCE_CXX_STD because they use multiple -std=
> options in one package.
>
> Defining FORCE_CXX_STD in textproc/icu/buildlink3.mk will break
> their builds.

Just one nitpick: icu's configure.ac mentions adding c++17 if no
-std is set. Are you going for gnu++17 because of the "GXX" test
beforehand?

(BTW this _is_ new in icu 75.1. 74.2 just checked for std:string_view.)

(I think harfbuzz-icu might have the same problem)


Cheers,

Patrick