Re: suggestion: pkg_add should stat all libs in REQUIRES, at least base libs

[Roland Illig <roland.illig%gmx.de@localhost>]

Am 21.08.2024 um 20:03 schrieb Thomas Klausner:
> On Tue, Jul 23, 2024 at 07:19:21AM -0400, Greg Troxel wrote:
>> The concrete suggestion is for pkg_add, before commmiting to add a
>> package, to:
>>
>>   - extract the REQUIRES list of libs
>>   - for each lib that is not in $LOCALBASE
>>       stat the lib
>>       throw an exception if missing
>
> Here's an implementation of it.
I'd prefer to list all missing files instead of only the first.

The indentation of the 'if (stat' line and the following line is using
spaces, should be tabs.

The warning "install the X sets" should only occur on NetBSD, as other
operating systems have different packaging strategies for their base system.

The check for S_ISLNK should be unnecessary since you are using stat(2),
not lstat(2).

Roland