Re: ocaml, dune, environment, PKG_CONFIG in the environment

[Greg Troxel <gdt%lexort.com@localhost>]

Taylor R Campbell <campbell+netbsd-tech-pkg%mumble.net@localhost> writes:

>> Date: Sun, 24 Nov 2024 09:42:04 -0500
>> From: Greg Troxel <gdt%lexort.com@localhost>
>> 
>> I just committed a kludge to ocaml-lablgtk3 that lets it build.
>> Essentially, dune seems to choke if PKG_CONFIG is defined in the
>> environment.  That's probably a dune bug to be fixed, but for now
>> avoiding that seems to build a working package.
>
> The attached patch fixes the bug in dune, which is that it tries to
> search PATH for $PKG_CONFIG even if $PKG_CONFIG is absolute.
>
> With this patch applied and your recent changes to ocaml-lablgtk3
> reverted, ocaml-lablgtk3 builds for me.  I'll leave it to you folks to
> decide whether it's risky to commit and maybe test in a bulk build
> first.

I lean to committing, as this is clearly a bug, and the theory behind
your fix is exactly consistent with the evidence.

We'll see what wiz and dholland think.