Re: [PATCH] cmake/build.mk: Hide non-buildlink3 libraries from cmake

[Taylor R Campbell <riastradh%NetBSD.org@localhost>]

> Date: Thu, 9 Jan 2025 20:07:04 +0000
> From: Taylor R Campbell <riastradh%NetBSD.org@localhost>
> 
> > Date: Wed, 25 Dec 2024 03:35:50 +0000
> > From: Taylor R Campbell <riastradh%NetBSD.org@localhost>
> > 
> > The attached patch changes devel/cmake/build.mk to set
> > CMAKE_FIND_USE_CMAKE_SYSTEM_PATH to OFF, and add BUILDLINK_DIR to
> > CMAKE_PREFIX_PATH, so that:
> > 
> > 1. cmake will not look in LOCALBASE by default.
> > 2. cmake will look in BUILDLINK_DIR by default.
> 
> Turns out it is also necessary to explicitly allow directories like
> /usr/include and /usr/lib -- that is, anything listed in
> COMPILER_INCLUDE_DIRS and COMPILER_LIB_DIRS -- or else packages fail
> to find base libraries like libm, libpthread, libz.

This makes a lot more progress in the bulk build.  Sampling of new
build failures below -- this covers everything I found that is likely
to be related to this change.  Most of it is probably either:

(a) missing buildlink3 includes, or
(b) missing symlinks under ${BUILDINK_DIR} requiring BUILDINK_FILES.*
    additions.


* archivers/kf6-karchive (ditto various other kf6-* packages)

  CMake Error at /tmp/pkgbuild/2024Q4/archivers/kf6-karchive/work/.buildlink/qt6/lib/cmake/Qt6CoreTools/Qt6CoreToolsTargets.cmake:197 (message):
    The imported target "Qt6::syncqt" references the file

       "/tmp/pkgbuild/2024Q4/archivers/kf6-karchive/work/.buildlink/qt6/libexec/syncqt"

    but this file does not exist.  [...]

* archivers/lxqt-archiver

  CMake Error in src/CMakeLists.txt:                   
    Imported target "fm-qt6" includes non-existent path

      "/tmp/pkgbuild/2024Q4/x11/libfm-qt/work/.buildlink/include/glib-2.0"

    in its INTERFACE_INCLUDE_DIRECTORIES.  [...]

* audio/qmmp

  => Checking file-check results for qmmp-1.6.5nb12
  ERROR: ************************************************************
  ERROR: The following files are in the PLIST but not in /tmp/pkgbuild/2024Q4/audio/qmmp/work/.destdir/pkg/2024Q4:
  ERROR:         /tmp/pkgbuild/2024Q4/audio/qmmp/work/.destdir/pkg/2024Q4/lib/qmmp-1.6/General/libgnomehotkey.so
  ERROR:         /tmp/pkgbuild/2024Q4/audio/qmmp/work/.destdir/pkg/2024Q4/lib/qmmp-1.6/General/libkdenotify.so
  ERROR:         /tmp/pkgbuild/2024Q4/audio/qmmp/work/.destdir/pkg/2024Q4/lib/qmmp-1.6/General/libmpris.so
  ERROR:         /tmp/pkgbuild/2024Q4/audio/qmmp/work/.destdir/pkg/2024Q4/lib/qmmp-1.6/General/libsleepinhibitor.so
  ERROR:         /tmp/pkgbuild/2024Q4/audio/qmmp/work/.destdir/pkg/2024Q4/lib/qmmp-1.6/General/libudisks.so
  ERROR:         /tmp/pkgbuild/2024Q4/audio/qmmp/work/.destdir/pkg/2024Q4/share/qmmp-1/images/app_icon.png
  ERROR:         /tmp/pkgbuild/2024Q4/audio/qmmp/work/.destdir/pkg/2024Q4/share/qmmp-1/images/empty_cover.png

* cad/librecad

  cd src/ && ( test -e Makefile || /pkg/2024Q4/qt5/bin/qmake -o Makefile /tmp/pkgbuild/2024Q4/cad/librecad/work/LibreCAD-2.2.0-rc2/librecad/src/src.pro 'CONFIG+=release BOOST_DIR=/pkg/2024Q4 BOOST_LIBDIR=/pkg/2024Q4/lib MUPARSER_DIR=/pkg/2024Q4 QMAKE_LFLAGS_RELEASE= DISABLE_POSTSCRIPT=true' ) && /pkg/2024Q4/bin/bmake -f Makefile all
  Project ERROR: Boost installation not found.
  *** Error code 3

  Stop.
  bmake[1]: stopped making "all" in /tmp/pkgbuild/2024Q4/cad/librecad/work/LibreCAD-2.2.0-rc2/librecad

* cad/occt

  CMake Error at CMakeLists.txt:875 (message):
    Could not find libraries of used third-party products:     
    3RDPARTY_TCL_LIBRARY_DIR 3RDPARTY_TK_LIBRARY_DIR

* editors/neovim

  CMake Error at /pkg/2024Q4/share/cmake-3.31/Modules/FindPackageHandleStandardArgs.cmake:233 (message):
    Could NOT find Lpeg (missing: LPEG_LIBRARY)
  Call Stack (most recent call first):
    /pkg/2024Q4/share/cmake-3.31/Modules/FindPackageHandleStandardArgs.cmake:603 (_FPHSA_FAILURE_MESSAGE)
    cmake/FindLpeg.cmake:3 (find_package_handle_standard_args)        
    src/nvim/CMakeLists.txt:34 (find_package)

* emulators/duckstation-qt

  CMake Error at /tmp/pkgbuild/2024Q4/emulators/duckstation-qt/work/.buildlink/qt6/lib/cmake/Qt6LinguistTools/Qt6LinguistToolsTargets.cmake:142 (message):
    The imported target "Qt6::lconvert" references the file        

       "/tmp/pkgbuild/2024Q4/emulators/duckstation-qt/work/.buildlink/qt6/bin/lconvert"

    but this file does not exist.  [...]

* games/openrct2

  CMake Error at /pkg/2024Q4/share/cmake-3.31/Modules/FindPackageHandleStandardArgs.cmake:233 (message):
    Failed to find all ICU components (missing: ICU_INCLUDE_DIR ICU_LIBRARY uc)
    (Required is at least version "59.0")
  Call Stack (most recent call first):
    /pkg/2024Q4/share/cmake-3.31/Modules/FindPackageHandleStandardArgs.cmake:603 (_FPHSA_FAILURE_MESSAGE)
    /pkg/2024Q4/share/cmake-3.31/Modules/FindICU.cmake:299 (find_package_handle_standard_args)
    src/openrct2/CMakeLists.txt:185 (find_package)
    CMakeLists.txt:381 (include)

* net/qbittorrent

  -- Could NOT find Qt6LinguistTools (missing: Qt6LinguistTools_DIR) 
  -- Could NOT find Qt6LinguistTools (missing: Qt6LinguistTools_DIR)
  CMake Error at cmake/Modules/CheckPackages.cmake:49 (find_package):
    Found package configuration file:

      /tmp/pkgbuild/2024Q4/net/qbittorrent/work/.buildlink/qt6/lib/cmake/Qt6/Qt6Config.cmake

    but it set Qt6_FOUND to FALSE so package "Qt6" is considered to be NOT
    FOUND.  Reason given by package:

    Failed to find required Qt component "LinguistTools".

    Expected Config file at
    "/tmp/pkgbuild/2024Q4/net/qbittorrent/work/.buildlink/qt6/lib/cmake/Qt6LinguistTools/Qt6LinguistToolsConfig.cmake"
    does NOT exist

* net/transmission-qt

  CMake Error at CMakeLists.txt:443 (message):
    Unable to find required Qt libraries (Qt6)

* print/scribus-qt5

  CMake Error at /pkg/2024Q4/share/cmake-3.31/Modules/FindPackageHandleStandardArgs.cmake:233 (message):
    Could NOT find JPEG (missing: JPEG_LIBRARY JPEG_INCLUDE_DIR)      
  Call Stack (most recent call first):
    /pkg/2024Q4/share/cmake-3.31/Modules/FindPackageHandleStandardArgs.cmake:603 (_FPHSA_FAILURE_MESSAGE)
    /pkg/2024Q4/share/cmake-3.31/Modules/FindJPEG.cmake:107 (find_package_handle_standard_args)
    CMakeLists_Dependencies.cmake:188 (find_package)
    CMakeLists.txt:427 (include)