Re: SHA3 implementation in src

[Taylor R Campbell <campbell+netbsd-tech-security%mumble.net@localhost>]

   Date: Sat, 5 Mar 2016 16:20:07 -0800
   From: Alistair Crooks <agc%pkgsrc.org@localhost>

   Any objections to adding Taylor Campbell's implementation of sha3 to src?

   Proposed diffs in:

   http://ftp.netbsd.org/pub/NetBSD/misc/agc/sha3-src-20160305.diff

The last time I proposed this, before SHA-3 was finalized, joerg
objected to it because overlap between libc and OpenSSL libcrypto for
the sha2 functions had historically caused a lot of trouble, and he
anticipated similar problems with an analogous sha3 API.

Smaller issues, OpenSSL aside:

- I wrote a man page for my SHA-3 code at
  <http://mumble.net/~campbell/hg/sha3/SHA3.3> -- you might want to
  use that instead of copying the SHA-2 one, which makes incorrect
  claims such as `This implementation of the SHA functions was written
  by Aaron D. Gifford'.  There's also a man page for the SHAKE API:
  <http://mumble.net/~campbell/hg/sha3/SHAKE.3>.

- I included atf tests in my last proposal.  If we go through with
  this, atf tests needn't necessarily be in the first commit but we
  should include them.

- No need to define __BEGIN_DECLS if you include <sys/cdefs.h>?