Re: _dirdesc in tools/compat/compat_defs.h

[christos%astron.com@localhost (Christos Zoulas)]

In article <1235999260.816241.24172.nullmailer%galant.ukfsn.org@localhost>,
Iain Hibbert  <plunky%rya-online.net@localhost> wrote:
>On Fri, 27 Feb 2009, Luke Mewburn wrote:
>
>> It may be some weirdness in tools/compat and its dirfd() macro,
>> or associated code.
>>
>> I'd look further into tools/compat/compat_defs.h and friends.
>
>Kind of unrelated to my opendir problem, I noticed that in that file there
>is a difference in the faked _dirdesc structure and the real one from
><dirent.h> which christos changed a couple of years ago:
>
>http://cvsweb.netbsd.org/bsdweb.cgi/src/include/dirent.h.diff?r1=1.28&r2=1.29
>
>I think its unlikely to cause a problem, but should it be corrected?
>
>iain
>
>--- /usr/src/tools/compat/compat_defs.h        2009-01-26 11:00:52.000000000 
>+0000
>+++ compat_defs.h      2009-03-02 10:31:31.000000000 +0000
>@@ -214,7 +214,7 @@ struct _dirdesc {
>       char    *dd_buf;        /* data buffer */
>       int     dd_len;         /* size of data buffer */
>       off_t   dd_seek;        /* magic cookie returned by getdents */
>-      long    dd_rewind;      /* magic cookie for rewinding */
>+      void    *dd_internal;   /* state for seekdir/telldir */
>       int     dd_flags;       /* flags for readdir */
>       void    *dd_lock;       /* lock for concurrent access */
> };

Yes, it should.

christos