Re: make: don't use bogus $TMPDIR

[christos%zoulas.com@localhost (Christos Zoulas)]

On Apr 22, 10:39pm, dholland-tech%netbsd.org@localhost (David Holland) wrote:
-- Subject: Re: make: don't use bogus $TMPDIR

| On Thu, Apr 22, 2010 at 06:37:49PM +0000, Christos Zoulas wrote:
|  > >+ /*
|  > >+  * Honor $TMPDIR but only if it is valid.
|  > >+  * Ensure it ends with /.
|  > >+  */
|  > >+ tmpDir = Var_Subst(NULL, "${TMPDIR:tA:U/tmp}/", VAR_GLOBAL, 0);
|  > 
|  > Looks good, but:
|  >            "${TMPDIR:tA:U" _PATH_TMP "}"
| 
| ...should be "${TMPDIR:tA:U" _PATH_TMP "}/" in case $TMPDIR doesn't
| have a slash on the end.

Good point!

christos