Re: Initial LLVM/clang patch

[Alistair Crooks <agc%pkgsrc.org@localhost>]

Hi Joerg,

On Thu, Feb 03, 2011 at 02:08:30AM +0100, Joerg Sonnenberger wrote:
> attached patch + tarball contain enough magic to get a working clang for
> AMD64. I could like to get this into the tree to make it simpler to test
> and integrated the changes required for doing a (almost) full world
> build. Things like support for !x86 targets in clang etc can be provided
> incrementally as well.

It would be great to get more support for external toolchains into the
tree.  This will become more and more important over the next few
years.
 
> At the moment, I do not plan to import the upstream LLVM or clang
> sources. src/external/llvm/Makefile has a checkout target using svn to
> get the "proven" revision as specified in Makefile.inc. This avoids
> having to deal with regular imports and repo churn associated.

That's a neat trick, but I feel it's not the right way to attack the
issues:

1.  checking existing version informatino, and optionally downloading,
verifying integrity, making sure pre-reqs are in place, configuring
for the host, building and packaging up the result are best done in
pkgsrc - that's what it's designed for.  Re-inventing a subset of this
in src strikes of point solutions and re-inventing wheels.

2. Doing this in src means that no binary packages for the toolchain.
For me, that's a necessity for an external toolchain.

3. serious build farms are in walled off areas, accessible only through
draconian security measures. All output is signed, and snapshots are
taken and preserved of the results. That might prove problematic for
this implementation.

4. A subversion client is needed to do this, so we need some form of
pkgsrc installed. We've always taken the view that the tools needed to
download and build src are in src - hence cvs's presence, etc. To me,
this is asking a bit too much.

> Status is that with a bunch of other patches and some smaller hacks,
> the AMD64 release build finishes almost. The GCC libraries and bootxx
> are the primary issues.

Now that is way cool!

Many thanks, Joerg.

Best,
Alistair