tech-toolchain archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
build.sh rumptest failing
Dear list,
The build.sh rumptest target fails at link test step, after the addition
of the do_sys_sync() call in kern_pmf.c, a while back [1]
[1] http://nxr.netbsd.org/xref/src/sys/kern/kern_pmf.c?a=true#323
[...]
kern_pmf.c:(.text+0xd65): undefined reference to `rumpns_do_sys_sync'
ERROR: Testlink of rump failed:
-lrumpdev -lrump
*** BUILD ABORTED ***
The fix is pretty trivial, add librumpvfs to the link test. However,
from design perspective, is it really correct to have a dependency on
vfs just for the do_sys_sync() case? All those linked against rumpdev
will have to pull rumpvfs in, just for this mere sync call...
Index: build.sh
===================================================================
RCS file: /cvsroot/src/build.sh,v
retrieving revision 1.251
diff -u -p -r1.251 build.sh
--- build.sh 17 Oct 2011 16:22:12 -0000 1.251
+++ build.sh 5 Dec 2011 02:37:50 -0000
@@ -1830,7 +1830,7 @@ installworld()
RUMP_LIBSETS='
-lrump,
-lrumpvfs -lrump,
- -lrumpdev -lrump,
+ -lrumpvfs -lrumpdev -lrump,
-lrumpnet -lrump,
-lrumpkern_tty -lrumpvfs -lrump,
-lrumpfs_tmpfs -lrumpvfs -lrump,
(please keep me on CC for that one)
--
Jean-Yves Migeon
jym%NetBSD.org@localhost
Home |
Main Index |
Thread Index |
Old Index