tech-toolchain archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Toolifying nbmake properly?



On Wed, Jan 10, 2018 at 02:45:07 +0300, Valery Ushakov wrote:

> On Tue, Jan 09, 2018 at 16:20:12 +0300, Valery Ushakov wrote:
> 
> > distrib/sets/sets.subr has arch_to_cpu() function that uses make to
> > get MACHINE_CPU.  Slighly reformatted for clarity:
> > 
> >     MAKEFLAGS= MAKEVERBOSE= MACHINE_ARCH=${1} \
> >     ${MAKE} -B -f- all <<EOMAKE
> > .include <bsd.own.mk>
> > all:
> > 	@echo \${MACHINE_CPU}
> > EOMAKE
> 
> How about attached patch that adds the appropriate -m?  
> 
> The old code probably predates make -V, so I've also changed the code
> to use it.

I've committed the fix.  This seems to be a recent regression
introduced with:

  revision 1.181
  date: 2017-11-23 02:14:01 +0300;  author: kre;  state: Exp;  lines: +4 -4;  commitid: iYB0xG0Ae9X0s5gA;

  Ignore MAKEFLAGS for snippet makefiles.
  (more important than MAKEVERBOSE probably.)

so there are no pullups necessary.

-uwe


Home | Main Index | Thread Index | Old Index