tech-toolchain archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: make :Q breakage



In article <20180526183207.E301C17FDB9%rebar.astron.com@localhost>,
Christos Zoulas <christos%zoulas.com@localhost> wrote:
>
>Also the common use of :Q right now is to quote for recursive invocations
>of make, so I am going to have to go and change all the :Q's to :Qm's in
>the tree.

I did not realize how popular :Q was :-(...

$ find . \( -name \*.mk -or -name Makefile\* \) -exec fgrep :Q {} + | wc
     438    1729   32941

Good thing that not many cases contain $'s otherwise we would have noticed
this sooner. Pkgsrc uses :Q in a ton of places too.

Given that most of those uses are recursive make invocations and that
they will need to be changed to :Qm the moment a variable passed contains
a $, I revise my proposal to make :Q quote '$' by default, and make
:Qs retain the original behavior for the few cases that need it.

How does that sound?

christos



Home | Main Index | Thread Index | Old Index