On Sun, 2020-03-08 at 14:18 +0000, Christos Zoulas wrote: > In article <9a9703652041c21dbb6286958b50dc58197cc168.camel%gentoo.org@localhost>, > Micha� Górny <mgorny%gentoo.org@localhost> wrote: > > -=-=-=-=-=- > > > > On Fri, 2020-03-06 at 10:21 +1100, matthew green wrote: > > > generally, LGTM. > > > > > > however, these are normally generated files. > > > > > > can you try to run mknative-gcc for at least one platform to > > > confirm you get the same result? otherwise this may be lost > > > in a future update... if you can't get it work, let me know. > > > > > > see src/tools/gcc/README.mknative. > > > > > > > Indeed I can't get it to work. > > > > Firstly, MKMAINTAINERTOOLS=yes is failing. I can proceed without it > > without hitting any issue related to gettext but... > > You don't need to set that. At least I never did. > > 1. run a complete build (or at least finish building tools and libraries > for the platform you want to generate). > 2. In /usr/src/tools/gcc run $TOOLDIRFORTHEPLATFORM/bin/nbmake-$ARCH native-gcc > Thank you. I've confirmed that after reverting my patch, mknative reenables both errno consts, so my patch is apparently doing the right thing ;-). I'll commit it now, and hopefully get to see releng results tomorrow. -- Best regards, Michał Górny
Attachment:
signature.asc
Description: This is a digitally signed message part