Re: [PATCH 0/7] LLDB import to src

[Joerg Sonnenberger <joerg%bec.de@localhost>]

On Sat, Mar 28, 2020 at 02:52:03PM +0100, Michał Górny wrote:
> This patch series imports LLDB as of the commit matching our LLVM
> and Clang (as necessary for API compatibility), backports important
> patches improving NetBSD support and adds Makefiles to build it.

I'm in the process of upgrading LLVM, but there are a couple of
regressions that need to get resolved first. I'll take a look soonish to
integrate this, but I don't plan to merge it before that.

Main issues with LLVM are currently:
(1) The still pending fix for the .eh_frame regression on amd64.
(2) A 32bit ARM specific bug in the machine code lowering triggered by
the DRM code.
(3) A decision on how to deal with the unconditional addition of new
note.gnu_property tags on aarch64 which our binutils version doesn't
support.

There is also the -fcommon mess to get sorted out, I can drop a list of
directories that need fixing.

> The build is currently purely using static libraries.  However, I think
> we should switch to building and using liblldb.so long-term as upstream
> expects us to.  This will require building LLVM and Clang with -fPIC,
> and it will then probably make sense to build libLLVM.so
> and libclang-cpp.so as well.

I don't see any reason why building LLDB dynamically would really
improve things given that we don't do Python scripting anyway. Building
clang with -fPIC is certainly a big no-go.

Joerg