tech-toolchain archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: nbctfmerge handling of outfile



On Tue, Dec 26, 2023 at 22:25:22 +0300, Valery Ushakov wrote:

> Native ctfmerge on netbsd doesn't delete its output on failure.  Cf.
> src/external/cddl/osnet/dist/tools/ctf/cvt/ctfmerge.c - the ifdef in
> terminate_cleanup.
> 
> However that ifdef doesn't kick in for tools build on non-netbsd
> hosts, that makes nbctfmerge behave differently from the native one.

Forgot to add, the function comment for handle_sig just above explains
why outfile is unlinked.  So I wonder why choose not to.  The proposed
patch just aligns native and tools behavior and doesn't constitute
endorsment of that behavior :).

-uwe


Home | Main Index | Thread Index | Old Index