Subject: Re: pppoe(4) man page in conjunction with Postfix leaves gaping relay
To: Jun-ichiro itojun Hagino <itojun@itojun.org>
From: Nino Dehne <TeCeEm@gmx.de>
List: tech-userlevel
Date: 10/02/2003 03:42:35
Jun-ichiro itojun Hagino wrote:

> 	does it address your problem?

To be honest: I don't know, or more like: I don't know if it treats the 
issue completely. From my limited ability to read code I suppose it 
adjusts the netmask upon receiving the addresses from the peer? I 
thought it would be good to fix the man pages to include the proper mask 
in the examples, since point-to-point links generally should have a mask 
of 0xffffffff, right? Maybe both places (driver and man pages) should 
get a look. I really can't comment on the code.


> itojun
>
> @@ -4799,8 +4801,13 @@
>  				*dest = new_dst; /* fix dstaddr in place */
>  			}
>  		}
> +		if (myaddr != 0 || hisaddr != 0) {
> +			memset(mask, 0, sizeof(*mask));
> +			mask->sin_len = sizeof(*mask);
> +			mask->sin_addr.s_addr = 0xffffffff;
> +		}
>  		error = in_ifinit(ifp, ifatoia(ifa), &new_sin, 0);
> -		if(debug && error)
> +		if (debug && error)
>  		{
>  			log(LOG_DEBUG, "%s: sppp_set_ip_addrs: in_ifinit "
>  			" failed, error=%d\n", ifp->if_xname, error);

regards

-- 
Of course it runs NetBSD.

PGP key: 42A5E773 / 41DE 4A4C DB34 33F7 2044  8FE0 91AA C584 42A5 E773