This is a multi-part message in MIME format.

--Multipart=_Tue__19_Oct_2004_17_40_04_+0300_3rCco+WBMS7jxiAQ
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Fri, 15 Oct 2004 18:46:27 +0200 mouss <usebsd@free.fr> wrote:

> Mike M. Volokhov wrote:
> 
> > However, I meant a single log, i.e. when at a boot time the output will
> > grew too much (for example up to few megabytes). In this case variables
> > will store huge sets of data. Is it ok?
> > 
> 
> I tested your modifs with a dummy script (that outputs about 20M) and 
> noticed no special problem (except that _rclogbuf initialization causes 
> a blank line to be appended but that's not a serious problem). However, 
> this may be an issue for small systems.

In any case we must decide what way we're using (tee or var) *before*
command execution. There is possible situation where we use tee method
and some rc.d script creates behaviour where /var/log/rc.log becomes
unavailable. This means that tee will fail. It possible to workaround by
buffering any output and then flushing buffer after each rc.d script
when /var/log/rc.log becomes available.

Relative to blank lines - it has been fixed.

> 
> Now there is a third approach: add an rc.d/rclog script that is run 
> after /var and /usr are mounted, and that changes the behaviour of 
> rclog() to use tee instead of buffering.

Having reread the whole thread once more, I use the following way:

- Log via tee(1) when it available, and accumulate log in buffer, when
  it is not.
- If tee can be used again, rclog() flushes buffer to log file and
  restores tee logging. Thus, logging methods may be switched unlimited
  times during both rc and rc.shutdown execution.
- If all rc.d scripts are finished and buffer still contain any data, I
  assume this data cannot be saved to /var/log/rc.log and thus I try to
  append it to /etc/rclog.tmp (see also my notes about buffering).
- As soon as log files becomes available rclog() rotate logs. Any further
  rclog() calls doesn't affected on log rotation.

> One potential issue with buffering is that output is printed after the 
> script terminates. If the script is verbose (that's bad but...), it's 
> output is delayed and once the script terminates, you get it all at 
> once. Fortunately, the log is here!

Partially fixed (will be delayed for one line only). In many verbose
scripts such as rc.d/network it looks good enough.

> PS. shutdown log should go to another place (shutdown.log?).
> Otherwise, it gets moved to rc.prev after reboot, so you lose the 
> previous startup logs (which may be useful for comparisons).

Please see above.

Well, could you test, please, my yet another patch to rc, rc.shutdown,
and rc.subr (in attachment)?

--
Best wishes,
Mishka.

--Multipart=_Tue__19_Oct_2004_17_40_04_+0300_3rCco+WBMS7jxiAQ
Content-Type: text/plain;
 name="rclog.patch"
Content-Disposition: attachment;
 filename="rclog.patch"
Content-Transfer-Encoding: base64

LS0tIHJjLm9yaWcJMjAwNC0xMC0xOSAxNzoyMjoyMC4wMDAwMDAwMDAgKzAzMDAKKysrIHJjCTIw
MDQtMTAtMTkgMTc6MjM6MDguMDAwMDAwMDAwICswMzAwCkBAIC0xNyw2ICsxNyw4IEBACiAuIC9l
dGMvcmMuY29uZgogX3JjX2NvbmZfbG9hZGVkPXRydWUKIAorX3JjX3N0YXRlPWJvb3QKKwogaWYg
ISBjaGVja3llc25vIHJjX2NvbmZpZ3VyZWQ7IHRoZW4KIAllY2hvICIvZXRjL3JjLmNvbmYgaXMg
bm90IGNvbmZpZ3VyZWQuICBNdWx0aXVzZXIgYm9vdCBhYm9ydGVkLiIKIAlleGl0IDEKQEAgLTM1
LDEzICszNywxOSBAQAogdHJhcCA6IElOVAogdHJhcCAiZWNobyAnQm9vdCBpbnRlcnJ1cHRlZC4n
OyBleGl0IDEiIFFVSVQKIAotZGF0ZQorcmNsb2cgImVjaG8gU3RhcnRpbmcgdXAgYXQgYGRhdGVg
IgogCiBmaWxlcz0kKHJjb3JkZXIgLXMgbm9zdGFydCAke3JjX3Jjb3JkZXJfZmxhZ3N9IC9ldGMv
cmMuZC8qKQogCiBmb3IgX3JjX2VsZW0gaW4gJGZpbGVzOyBkbwotCXJ1bl9yY19zY3JpcHQgJF9y
Y19lbGVtIHN0YXJ0CisJcmNsb2cgInJ1bl9yY19zY3JpcHQgJF9yY19lbGVtIHN0YXJ0IgogZG9u
ZQogCi1kYXRlCityY2xvZyAiZWNobyBTeXN0ZW0gd2FzIHN0YXJ0ZWQgYXQgYGRhdGVgIgorCitp
ZiBjaGVja3llc25vIHJjX2xvZ19vdXRwdXQgJiYgWyAtbiAiJF9yY2xvZ2J1ZiIgXTsgdGhlbgor
CXdhcm4gInN0YWxlIGxvZyBmb3VuZCBpbiBidWZmZXI7IHNhdmluZyB0byAvZXRjL3JjbG9nLnRt
cCIKKwllY2hvICIkX3JjbG9nYnVmIiA+PiAvZXRjL3JjbG9nLnRtcAorZmkKKwogZXhpdCAwCi0t
LSByYy5zaHV0ZG93bi5vcmlnCTIwMDQtMTAtMTkgMTc6MjI6MjAuMDAwMDAwMDAwICswMzAwCisr
KyByYy5zaHV0ZG93bgkyMDA0LTEwLTE5IDE3OjIzOjE1LjAwMDAwMDAwMCArMDMwMApAQCAtMTQs
NiArMTQsOCBAQAogLiAvZXRjL3JjLnN1YnIKIC4gL2V0Yy9yYy5jb25mCiAKK19yY19zdGF0ZT1z
aHV0ZG93bgorCiBpZiAhIGNoZWNreWVzbm8gZG9fcmNzaHV0ZG93bjsgdGhlbgogCWVjaG8gIlNr
aXBwaW5nIHNodXRkb3duIGhvb2tzLiIKIAlleGl0IDAKQEAgLTQzLDYgKzQ1LDcgQEAKIAlfcmNz
aHV0ZG93bl93YXRjaGRvZz0kIQogZmkKIAorcmNsb2cgImVjaG8gU3lzdGVtIGdvaW5nIGRvd24g
YXQgYGRhdGVgIgogCiAjCURldGVybWluZSB0aGUgc2h1dGRvd24gb3JkZXIgb2YgdGhlIC9ldGMv
cmMuZCBzY3JpcHRzLAogIwlhbmQgcGVyZm9ybSB0aGUgb3BlcmF0aW9uCkBAIC01MCw3ICs1Myw3
IEBACiBmaWxlcz0kKHJjb3JkZXIgLWsgc2h1dGRvd24gJHtyY3NodXRkb3duX3Jjb3JkZXJfZmxh
Z3N9IC9ldGMvcmMuZC8qKQogCiBmb3IgX3JjX2VsZW0gaW4gJChyZXZlcnNlX2xpc3QgJGZpbGVz
KTsgZG8KLQlydW5fcmNfc2NyaXB0ICRfcmNfZWxlbSBzdG9wCisJcmNsb2cgInJ1bl9yY19zY3Jp
cHQgJF9yY19lbGVtIHN0b3AiCiBkb25lCiAKIApAQCAtNjAsNSArNjMsMTEgQEAKIAlraWxsIC1U
RVJNICRfcmNzaHV0ZG93bl93YXRjaGRvZyA+L2Rldi9udWxsIDI+JjEKIGZpCiAKLWRhdGUKK3Jj
bG9nICJlY2hvIFJ1bm5pbmcgc2h1dGRvd24gc2NyaXB0cyBmaW5pc2hlZCBhdCBgZGF0ZWAiCisK
K2lmIGNoZWNreWVzbm8gcmNfbG9nX291dHB1dCAmJiBbIC1uICIkX3JjbG9nYnVmIiBdOyB0aGVu
CisJd2FybiAic3RhbGUgbG9nIGZvdW5kIGluIGJ1ZmZlcjsgc2F2aW5nIHRvIC9ldGMvcmNsb2cu
dG1wIgorCWVjaG8gIiRfcmNsb2didWYiID4+IC9ldGMvcmNsb2cudG1wCitmaQorCiBleGl0IDAK
LS0tIHJjLnN1YnIub3JpZwkyMDA0LTEwLTE5IDE3OjIyOjIwLjAwMDAwMDAwMCArMDMwMAorKysg
cmMuc3VicgkyMDA0LTEwLTE5IDE3OjI3OjUzLjAwMDAwMDAwMCArMDMwMApAQCAtODE5LDYgKzgx
OSw1NCBAQAogfQogCiAjCisjIHJjbG9nIGNvbW1hbmQKKyMJUnVuICJjb21tYW5kIiBhbmQgYXBw
ZW5kIGFsbCBvdXRwdXQgdG8gJF9yY2xvZ2J1ZiB2YXJpYWJsZS4KKyMKK3JjbG9nKCkKK3sKKwlf
cmNsb2djbWQ9JDEKKwlpZiBjaGVja3llc25vIHJjX2xvZ19vdXRwdXQ7IHRoZW4KKwkJOiAke19y
Y2xvZ2ZpbGU6PS92YXIvbG9nLyR7X3JjX3N0YXRlfS5sb2d9CisJCTogJHtfcmNsb2dmaWxlX3By
ZXY6PS92YXIvbG9nLyR7X3JjX3N0YXRlfS5wcmV2fQorCQlpZiBbIC14IC91c3IvYmluL3RlZSAt
YSAtZCAvdmFyL2xvZyBdOyB0aGVuIAorCQkJaWYgWyAteiAiJF9yY2xvZ19yb3RhdGVkIiBdOyB0
aGVuCisJCQkJZWNobyAiUm90YXRlIHJjICR7X3JjX3N0YXRlfSBsb2dzLiIKKwkJCQk6ICR7X3Jj
bG9nX3JvdGF0ZWQ6PSR7X3JjX3N0YXRlfX0KKwkJCQlpZiBbIC1mICR7X3JjbG9nZmlsZX0gXTsg
dGhlbgorCQkJCQltdiAtZiAke19yY2xvZ2ZpbGV9ICR7X3JjbG9nZmlsZV9wcmV2fQorCQkJCWZp
CisJCQlmaQorCQkJaWYgWyAtbiAiJF9yY2xvZ2J1ZiIgXTsgdGhlbgorCQkJCWVjaG8gLW4gIiRf
cmNsb2didWYiID4+ICR7X3JjbG9nZmlsZX0KKwkJCQlfcmNsb2didWY9CisJCQlmaQorCQkJJF9y
Y2xvZ2NtZCAyPiYxIHwgL3Vzci9iaW4vdGVlIC1hICR7X3JjbG9nZmlsZX0KKwkJZWxzZQorCQkJ
X3JjbG9nY21kYnVmPSQoICR7X3JjbG9nY21kfSAyPiYxIHwgX3JjdGVlX291dHB1dCApCisJCQlp
ZiBbIC1uICIkX3JjbG9nY21kYnVmIiBdOyB0aGVuCisJCQkJX3JjbG9nY21kYnVmPSIkX3JjbG9n
Y21kYnVmCisiCisJCQkJX3JjbG9nYnVmPSIke19yY2xvZ2J1Zn0ke19yY2xvZ2NtZGJ1Zn0iCisJ
CQlmaQorCQlmaQorCWVsc2UKKwkJJF9yY2xvZ2NtZAorCWZpCit9CisKKyMKKyMgX3JjdGVlX291
dHB1dAorIwlUYWtlIHN0ZGluIGxpbmUgYnkgbGluZSBhbmQgc2VuZCBpdCB0byBzdGRvdXQgYW5k
IHN0ZGVycgorIworX3JjdGVlX291dHB1dCgpCit7CisJd2hpbGUgcmVhZCBfcmN0ZWVfYnVmZmVy
OyBkbworCQllY2hvICIkX3JjdGVlX2J1ZmZlciIKKwkJZWNobyAiJF9yY3RlZV9idWZmZXIiIDE+
JjIKKwlkb25lCit9CisKKyMKICMgYmFja3VwX2ZpbGUgYWN0aW9uIGZpbGUgY3VyIGJhY2t1cAog
IwlNYWtlIGEgYmFja3VwIGNvcHkgb2YgYGZpbGUnIGludG8gYGN1cicsIGFuZCBzYXZlIHRoZSBw
cmV2aW91cwogIwl2ZXJzaW9uIG9mIGBjdXInIGFzIGBiYWNrdXAnIG9yIHVzZSByY3MgZm9yIGFy
Y2hpdmluZy4K

--Multipart=_Tue__19_Oct_2004_17_40_04_+0300_3rCco+WBMS7jxiAQ--