Subject: Removing "net_open: " from various libsa output
To: None <tech-userlevel@NetBSD.org>
From: Martin Husemann <martin@duskware.de>
List: tech-userlevel
Date: 09/17/2007 10:03:58
I'd like to propose to remove a lot of "net_open: " strings from various
src/sys/lib/libsa functions. They are always output, not only in debugging
builds, and IMHO they are ugly and useless (net_open is not even the
actual function name).
Here is one example patch (the change is purely mechanical):
Index: bootp.c
===================================================================
RCS file: /cvsroot/src/sys/lib/libsa/bootp.c,v
retrieving revision 1.29
diff -u -p -r1.29 bootp.c
--- bootp.c 20 May 2006 19:40:46 -0000 1.29
+++ bootp.c 17 Sep 2007 08:02:55 -0000
@@ -250,16 +250,16 @@ bootp(sock)
gateip.s_addr = 0;
}
- printf("net_open: client addr: %s\n", inet_ntoa(myip));
+ printf("client addr: %s\n", inet_ntoa(myip));
if (smask)
- printf("net_open: subnet mask: %s\n", intoa(smask));
+ printf("subnet mask: %s\n", intoa(smask));
if (gateip.s_addr != 0)
- printf("net_open: net gateway: %s\n", inet_ntoa(gateip));
- printf("net_open: server addr: %s\n", inet_ntoa(rootip));
+ printf("net gateway: %s\n", inet_ntoa(gateip));
+ printf("server addr: %s\n", inet_ntoa(rootip));
if (rootpath[0] != '\0')
- printf("net_open: server path: %s\n", rootpath);
+ printf("server path: %s\n", rootpath);
if (bootfile[0] != '\0')
- printf("net_open: file name: %s\n", bootfile);
+ printf("file name: %s\n", bootfile);
/* Bump xid so next request will be unique. */
++d->xid;
As always, there is no point in discussing personal taste, so this might
be controversial ;-)
Does anyone see a good reason to keep the prefix in the output?
Martin