Subject: lib/GL doesn't build
To: None <rtr@netbsd.org>
From: Hubert Feyrer <hubert.feyrer@informatik.fh-regensburg.de>
List: tech-x11
Date: 03/31/2004 02:44:40
Hi,

building src/x11 from the netbsd-2-0 branch and xsrc-current, I get an
error in src/lib/GL about assyntax.h not found. Looking at
src/x11/Makefile, I wonder how that could ever work, as 1) CPPFLAGS.${fn}
doesn't seem to get evaluated anywhere and 2) there's an -I for the
path to that file missing.

I wonder what I'm doing wrong here, and in what environment this was
tested successfully.

The patch below fixes things for me, what do you think about it?


 - Hubert



Index: Makefile
===================================================================
RCS file: /cvsroot/src/x11/lib/GL/Makefile,v
retrieving revision 1.5
diff -u -r1.5 Makefile
--- Makefile	6 Mar 2004 03:05:39 -0000	1.5
+++ Makefile	31 Mar 2004 00:39:02 -0000
@@ -19,9 +19,10 @@
 .PATH:		${X11SRCDIR.xc}/extras/Mesa/src/X86
 SRCS.glx+=	glapi_x86.S
 .for fn in ${SRCS.glx}
-CPPFLAGS.${fn}=	-DUSE_X86_ASM
+CPPFLAGS+=	-DUSE_X86_ASM
+CPPFLAGS+=	-I${X11SRCDIR.xc}/extras/Mesa/src/X86
 .endfor
-.endif
+.endif # i386


 .if ${X11DRI} != "no"

-- 
Hubert Feyrer <hubert@feyrer.de>