tech-x11 archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: redundant xf86-video-intel patches



   Date: Sun, 25 Jan 2015 15:57:48 +0000
   From: Patrick Welche <prlw1%cam.ac.uk@localhost>

   1) The only difference between drmIoctl and do_ioctl is that do_ioctl calls
      sched_yield() if ioctl returns EAGAIN. Why is calling sched_yield() a
      bad idea?

No idea about this.  I didn't do it.

   2)  Again, anyone remember what lead to us thinking that __kgem_bo_size()
       is doing the wrong thing?

       drmMap:
         pagesize_mask = getpagesize() - 1;
         size = (size + pagesize_mask) & ~pagesize_mask;
       mmap with call to bytes() => __kgem_bo_size():
         return PAGE_SIZE * bo->size.pages.count;

It used to be that mmap didn't work in drm2 because there was no way
to specify a custom mmap operation in fileops.  Now chs@ has adapted
uvm so that this works and so that that patch is no longer necessary.


Home | Main Index | Thread Index | Old Index