pkgsrc-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[pkgsrc/trunk]: pkgsrc/pkgtools/pkglint/files In checklines_direct_tools, quo...



details:   https://anonhg.NetBSD.org/pkgsrc/rev/52f72c0121f7
branches:  trunk
changeset: 494495:52f72c0121f7
user:      rillig <rillig%pkgsrc.org@localhost>
date:      Wed May 25 00:53:35 2005 +0000

description:
In checklines_direct_tools, quote shell commands, too. Unquoted shell
commands are too hard to recognize.

diffstat:

 pkgtools/pkglint/files/pkglint.pl |  4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diffs (21 lines):

diff -r 06090c80d1b2 -r 52f72c0121f7 pkgtools/pkglint/files/pkglint.pl
--- a/pkgtools/pkglint/files/pkglint.pl Wed May 25 00:00:24 2005 +0000
+++ b/pkgtools/pkglint/files/pkglint.pl Wed May 25 00:53:35 2005 +0000
@@ -11,7 +11,7 @@
 # Freely redistributable.  Absolutely no warranty.
 #
 # From Id: portlint.pl,v 1.64 1998/02/28 02:34:05 itojun Exp
-# $NetBSD: pkglint.pl,v 1.180 2005/05/25 00:00:24 rillig Exp $
+# $NetBSD: pkglint.pl,v 1.181 2005/05/25 00:53:35 rillig Exp $
 #
 # This version contains lots of changes necessary for NetBSD packages
 # done by:
@@ -1293,7 +1293,7 @@
                        my ($shellcmd) = ($1);
                        # process shell commands
                        if ($shellcmd !~ $regex_ok_shellcmds) {
-                               $line->log_warning("Possible direct use of \"${tool}\" in shell command ${shellcmd}. Please use \$\{$toolvar{$tool}\} instead.");
+                               $line->log_warning("Possible direct use of \"${tool}\" in shell command \"${shellcmd}\". Please use \$\{$toolvar{$tool}\} instead.");
                        }
                } elsif ($text =~ qr"^\.") {
                        # skip processing directives



Home | Main Index | Thread Index | Old Index