Re: CVS commit: pkgsrc/multimedia/vlc

[Alistair Crooks <agc%pkgsrc.org@localhost>]

On Sat, Nov 12, 2011 at 03:31:17AM +0100, John Marino wrote:
> So like I've been saying, PKG_DEVELOPER has been set, and in fact the 
> errors I saw probably came from that, and not the maligned Tinderbox.  
> Here's the important part of the log:
> 
> >=> Automatic manual page handling
> >=> Generating post-install file lists
> >=> Checking file-check results for vlc-1.1.12nb1
> >ERROR: ************************************************************
> >ERROR: The following files are in /usr/pkg but not in the PLIST:
> >ERROR:         
> >/work/multimedia/vlc/work/.destdir/usr/pkg/lib/vlc/plugins/access/libcdda_plugin.a
> >ERROR:         
> >/work/multimedia/vlc/work/.destdir/usr/pkg/lib/vlc/plugins/access/libcdda_plugin.la
> >ERROR:         
> >/work/multimedia/vlc/work/.destdir/usr/pkg/lib/vlc/plugins/access/libcdda_plugin.so
> >ERROR:         
> >/work/multimedia/vlc/work/.destdir/usr/pkg/lib/vlc/plugins/access/libvcd_plugin.a
> >ERROR:         
> >/work/multimedia/vlc/work/.destdir/usr/pkg/lib/vlc/plugins/access/libvcd_plugin.la
> >ERROR:         
> >/work/multimedia/vlc/work/.destdir/usr/pkg/lib/vlc/plugins/access/libvcd_plugin.so
> >*** Error code 1
> >
> >Stop.
> >bmake: stopped in /usr/pkgsrc/multimedia/vlc
> >*** Error code 1
> 
> What do you think?
> Does the PLIST seem wrong to you?

Yes, it does actually, just not in the way you think.

Around line 37 of the package Makefile, there's the construct:

.if ${OPSYS} == "NetBSD"
CONFIGURE_ARGS+=        --disable-vcd
.else
PLIST.vcd=              yes
# This may need a closer look.
PLIST.cdda=             yes
.endif

Now I don't have a DF system to hand, but I suspect that the correct
way to modify PLIST to fix this would be to use the PLIST.vcd and
PLIST.cdda constructs, to be understanding of operating systems which
are different from your own, and just in general wary of changing
things that others have been using fine up until now.  Use the
knowledge of the other pkgsrc developers, ask them before making
changes; after all, the worst that can happen is that they help you
out.

Regards,
Alistair

PS.  The only maligned thing about Tinderbox is that it's not the
right tool for the job.  This is pkgsrc, not the ports collection for
FreeBSD.  I have been using the ports collection for work for a while
now, and I am very distinctly happy that this is pkgsrc.