Re: CVS commit: pkgsrc/mk/tools

[Joerg Sonnenberger <joerg%britannica.bec.de@localhost>]

On Sat, Apr 14, 2012 at 05:05:39PM +1200, Steven Drake wrote:
> On Fri, 13 Apr 2012, Joerg Sonnenberger wrote:
> 
> > On Fri, Apr 13, 2012 at 02:25:07AM +0000, Steven Drake wrote:
> > > Module Name:      pkgsrc
> > > Committed By:     sbd
> > > Date:             Fri Apr 13 02:25:07 UTC 2012
> > > 
> > > Modified Files:
> > >   pkgsrc/mk/tools: replace.mk
> > > 
> > > Log Message:
> > > Use _TOOLS.pkg when using for loops in mk/tools/replace.mk so that pkglint
> > > can see them.
> > 
> > What's the point of this? 
> 
> "so that pkglint can see them", have a look at pkglint line 1970-1987
> and you'll see why.
> 
> > This seems to just add useless additional junk to the global variable 
> > namespace.
> 
> Agreed.
> 
> > pkglint should *not* care about them.
> 
> If you think it's wrong modify pkglint so it doesn't care.

I don't do Perl. I certainly find it wrong to change working and correct
code to make messing with the internals easier...

Joerg