Re: CVS commit: pkgsrc/mk/wrapper

[Joerg Sonnenberger <joerg%britannica.bec.de@localhost>]

On Sat, Apr 14, 2012 at 05:10:20PM +1200, Steven Drake wrote:
> On Fri, 13 Apr 2012, Joerg Sonnenberger wrote:
> 
> > On Fri, Apr 13, 2012 at 03:11:13AM +0000, Steven Drake wrote:
> > > Module Name:      pkgsrc
> > > Committed By:     sbd
> > > Date:             Fri Apr 13 03:11:13 UTC 2012
> > > 
> > > Modified Files:
> > >   pkgsrc/mk/wrapper: buildcmd
> > > 
> > > Log Message:
> > > Treat the '--as-needed' and '--no-as-needed' arguments to ld as if
> > > thay are librarys so that they still surround the given library.
> > > WARNING: this may not work if the wrapper reorders librarys.
> > 
> > Please make this a separate statement. This is just messing things up
> > without a good reason.
> 
> Why, if it was a separate statement it would just be duplicating the
> "-l*" statement body and how does this mess things up exactly, I put the
> comment there to explain why.

E.g. the logic separate "-l foo" doesn't apply etc. The handling for this
is isolated. Do not make this code more difficult to follow.

Joerg