Re: CVS commit: pkgsrc/net/xymon

["S.P.Zeidler" <spz%serpens.de@localhost>]

Hi David,

Thus wrote David Holland (dholland-pkgchanges%netbsd.org@localhost):

> On Thu, May 10, 2012 at 11:57:50PM +0200, S.P.Zeidler wrote:
>  > > The problem really does appear to be that it's installing files in an
>  > > OWN_DIRS dir, though.
>  > 
>  > By no means. That's what *_DIRS exist for.
> 
> It was complaining that a file is both in the PLIST and in
> CHECK_FILES_SKIP. OWN_DIRS puts things in CHECK_FILES_SKIP. It's not
> *that* broad a jump to deduce that these shouldn't be combined.

Ah, I see. Yes, that is a very nice red herring. 

>  > > (It usually doesn't in destdir mode.)
>  > 
>  > I'm not sure how you get to that conclusion.
> 
> As far as I know, in destdir mode, you need to create ${PREFIX}/bin
> explicitly, usually with INSTALLATION_DIRS.

Not only in destdir mode IME, e.g. $PREFIX/libexec may not yet exist for
an early package. MAKE_DIRS also creates the directory in the right phase.
The effective difference for a directory under PREFIX seems to be that
it gets put into CHECK_FILES_SKIP if listed in MAKE_DIRS but not if
in INSTALLATION_DIRS or REQD_DIRS.

If you have dir a in INSTALLATION_DIRS and subdir a/b in OWN_DIRS (because
it is expected to contain files that should not be deleted when
deinstalling the package for updates) deinstalling the package will
nuke a and thus also a/b. That's unfortunate.

I'll have to check the behaviour of REQD_DIRS and use that for XYMONTOPDIR
if that gives me both check_files and doesn't nuke the 'precious' subdirs.

regards,
        spz
-- 
spz%serpens.de@localhost (S.P.Zeidler)