Re: CVS commit: pkgsrc/cad/openscad

[John Marino <mfl-commissioner%marino.st@localhost>]

On 8/15/2012 19:08, David Holland wrote:
> On Mon, Aug 13, 2012 at 10:33:56PM +0000, John Marino wrote:
>   >  Modified Files:
>   >          pkgsrc/cad/openscad: Makefile distinfo
>   >  Added Files:
>   >          pkgsrc/cad/openscad/patches: patch-bison.pri patch-flex.pri
>   >
>   >  Log Message:
>   >  cad/openscad: Use wrappers for bison, USE_TOOLS-= flex
>   >
>   >  On DragonFly, the path for bison and lex were set to /usr/local/bin/bison
>   >  and /usr/local/bin/flex.  These were basically hardcoded.  The added
>   >  patches set the paths to "bison" and "flex" which pick up the
>   >  ${WRKDIR}/.tools/bin/ and ${PREFIX}/bin versions instead.
>   >
>   >  flex was removed from USE_TOOLS because the pkgsrc FlexLexer.h can build
>   >  openscad and the one that comes with DragonFly can't.  It was replaced
>   >  with the flex buildlink3 and it should work everywhere.
>
> Shouldn't this logic be dragonfly-only to avoid making everyone else
> build flex from pkgsrc?

I don't think so.
Unless we know for a fact that it only affects one platform now and 
forever, this fix is lasting and universal while the other only fixes 
DragonFly.

Somebody could probably uses options.mk to make it an option of which 
format to choose, but honestly I spent hours on this one.  I was tired.

John