Re: CVS commit: pkgsrc/cad/openscad

[David Holland <dholland-pkgchanges%netbsd.org@localhost>]

(wading through old stuff)
On Wed, Aug 15, 2012 at 07:27:11PM +0200, John Marino wrote:
 > >  >  Modified Files:
 > >  >         pkgsrc/cad/openscad: Makefile distinfo
 > >  >  Added Files:
 > >  >         pkgsrc/cad/openscad/patches: patch-bison.pri patch-flex.pri
 > >  >
 > >  >  Log Message:
 > >  >  cad/openscad: Use wrappers for bison, USE_TOOLS-= flex
 > >  >
 > >  >  On DragonFly, the path for bison and lex were set to 
 > > /usr/local/bin/bison
 > >  >  and /usr/local/bin/flex.  These were basically hardcoded.  The added
 > >  >  patches set the paths to "bison" and "flex" which pick up the
 > >  >  ${WRKDIR}/.tools/bin/ and ${PREFIX}/bin versions instead.
 > >  >
 > >  >  flex was removed from USE_TOOLS because the pkgsrc FlexLexer.h can 
 > > build
 > >  >  openscad and the one that comes with DragonFly can't.  It was replaced
 > >  >  with the flex buildlink3 and it should work everywhere.
 > >
 > >Shouldn't this logic be dragonfly-only to avoid making everyone else
 > >build flex from pkgsrc?
 > 
 > I don't think so.
 > Unless we know for a fact that it only affects one platform now and
 > forever, this fix is lasting and universal while the other only
 > fixes DragonFly.
 > 
 > Somebody could probably uses options.mk to make it an option of
 > which format to choose, but honestly I spent hours on this one.  I
 > was tired.

Well... ideally it should use this mechanism:

FLEX_REQD?=             2.5.4
# If the package does explicitly request flex as a tool, then determine if the
# platform-provided flex's version is at least ${FLEX_REQD}.  If it isn't, then
# tell the tools framework to use the pkgsrc flex.

and USE_TOOLS+=flex. Do you know what the version requirement is?

-- 
David A. Holland
dholland%netbsd.org@localhost