On Sun, 02 Sep 2012 04:10:23 +0900, John Marino <netbsd%marino.st@localhost> wrote:
On 9/1/2012 21:00, John Marino wrote:On 9/1/2012 20:40, John Marino wrote:On 9/1/2012 11:09, OBATA Akio wrote:On Sat, 01 Sep 2012 17:49:39 +0900, John Marino <netbsd%marino.st@localhost> wrote:This patch did not fix php-gettext - it still fails at the configure target due to being unable to locate libintl.h.For such cases, need to pass BUILDLINK_DIR instead of BUILDLINK_PREFIX.gettext to configure script. IMO, it is better to revert the change, sacrifice more than one gains.you know, this patch works on php-gettext outside of the bulk build, I confirmed that it didn't build without the patch and then rebuilding gettext-lib with the patch allowed php-gettext to configure. I applied it in the middle of the build, so maybe there's something out of config (even rebuilding gettext-lib inside bulk build didn't fix it). So let's not give up on this patch just yet. JohnI must have configured the wrong package because php-gettext doesn't build outside bulk either. However, I'm looking at config.m4 and configure.in and the script is looking at /usr/pkg/include/libintl.h instead of $WRKSRC/.buildlink/include/libintl. due to the CONFIGURE_ARG in the source package makefile. So your patch correctly fixes the .buildlink but this package isn't looking there.The attached patch to devel/php-gettext will fix the build. It works inside and outside the bulk build, but it references the .buildlink directory directly. Is that okay? It forces the configure script to look inside the wrappers first.
As I already said:
For such cases, need to pass BUILDLINK_DIR instead of BUILDLINK_PREFIX.gettext to configure script.
You should use ${BUILDLINK_DIR} instead of ${WRKDIR}/.buildlink.
But this kind of trick may introduce potentially $WRKDIR reference injection
into the result of built, so it should be taken carefully.
--
OBATA Akio / obache%NetBSD.org@localhost